From 6ba300a4c31339515416e525c75b8aa93568c505 Mon Sep 17 00:00:00 2001 From: Florent Tapponnier <160007691+Flotapponnier@users.noreply.github.com> Date: Wed, 26 Aug 2026 17:08:40 +0200 Subject: [PATCH] fix: show maker rebates as earned (green +), clarify savings when feesActual < 0 --- src/components/fee-compare-client.tsx | 28 ++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/components/fee-compare-client.tsx b/src/components/fee-compare-client.tsx index a7715ac9..8441d702 100644 --- a/src/components/fee-compare-client.tsx +++ b/src/components/fee-compare-client.tsx @@ -460,8 +460,10 @@ function SimBox({

{sim.saved > 0.5 && (

- {thisName} saved {fmtUsd(sim.saved)} - {sim.multiple && sim.multiple > 1.05 + {thisName} total advantage: {fmtUsd(sim.saved)} + {sim.feesActual < -0.01 + ? ` (${fmtUsd(sim.equivFees)} equiv + ${fmtUsd(Math.abs(sim.feesActual))} earned)` + : sim.multiple && sim.multiple > 1.05 ? ` (${fmt(sim.multiple, 1)}x cheaper)` : ""}

@@ -516,7 +518,10 @@ function WalletSide({

{crossSim.saved > 0.5 && (

- {venue.name} would cost {fmtUsd(Math.abs(crossSim.saved))} more + {otherVenue.name} total advantage: {fmtUsd(crossSim.saved)} + {crossSim.feesActual < -0.01 + ? ` (earned ${fmtUsd(Math.abs(crossSim.feesActual))} in rebates)` + : ""}

)} {crossSim.saved < -0.5 && ( @@ -550,10 +555,19 @@ function WalletSide({
-

- {fmtUsd(fees)} -

-

{fmt(avgBps, 2)} bps avg

+ {fees < -0.01 ? ( + <> +

+ +{fmtUsd(Math.abs(fees))} +

+

maker rebates earned

+ + ) : ( +

+ {fmtUsd(fees)} +

+ )} +

{fmt(Math.abs(avgBps), 2)} bps avg

{/* Venue-specific extra stats */}