From a943619cbba09fc03e51e7311b74fac706e9e7e3 Mon Sep 17 00:00:00 2001
From: Florent Tapponnier <160007691+Flotapponnier@users.noreply.github.com>
Date: Wed, 26 Aug 2026 21:23:38 +0200
Subject: [PATCH] fix: dYdX drop inaccurate funding, takers-only fills, timeout
 50s, Gains 6 pages

- Remove perpetualPositions funding fetch (not date-scopable, cumulative all-time)
- dYdX fills count = takers only (consistent with fee/notional calc)
- maxDuration 30 -> 50 to cover paginated fetches in parallel
- Gains MAX_PAGES 10 -> 6 (600 trades, safer budget)
- Footnote: note dYdX funding excluded
---
 src/app/api/fee-compare/route.ts      | 29 ++++++---------------------
 src/components/fee-compare-client.tsx |  3 +--
 2 files changed, 7 insertions(+), 25 deletions(-)

diff --git a/src/app/api/fee-compare/route.ts b/src/app/api/fee-compare/route.ts
index b1c1c7e1..f13b0730 100644
--- a/src/app/api/fee-compare/route.ts
+++ b/src/app/api/fee-compare/route.ts
@@ -3,7 +3,7 @@ import { clientKey, rateLimit, tooManyRequests } from "@/lib/rate-limit";
 import { keccak256 } from "js-sha3";
 
 export const runtime = "nodejs";
-export const maxDuration = 30;
+export const maxDuration = 50;
 
 const HL_API = "https://api.hyperliquid.xyz/info";
 const GAINS_VARS_URL = "https://backend-arbitrum.gains.trade/trading-variables";
@@ -499,23 +499,7 @@ async function fetchDydxFills(dydxAddress: string, cutoffMs: number): Promise<Dy
     page++;
   }
 
-  // fetch funding from perpetualPositions (netFunding = settled + unsettled)
-  let fundingUsd = 0;
-  try {
-    const pfRes = await fetch(
-      `${DYDX_INDEXER}/v4/perpetualPositions?address=${encodeURIComponent(dydxAddress)}&subaccountNumber=0&limit=100`,
-      { signal: AbortSignal.timeout(8000) }
-    );
-    if (pfRes.ok) {
-      const pfBody = (await pfRes.json()) as {
-        positions?: Array<{ netFunding?: string; closedAt?: string | null }>;
-      };
-      for (const p of pfBody.positions ?? []) {
-        fundingUsd += parseFloat(p.netFunding ?? "0");
-      }
-    }
-  } catch { /* funding is optional */ }
-
+  // Only count taker fills — maker fees are rebates and distort the comparison
   const takers = allFills.filter((f) => (f.liquidity ?? "").toUpperCase() !== "MAKER");
   let feesUsdc = 0;
   let notionalUsd = 0;
@@ -523,13 +507,12 @@ async function fetchDydxFills(dydxAddress: string, cutoffMs: number): Promise<Dy
     feesUsdc += parseFloat(f.fee);
     notionalUsd += parseFloat(f.price) * parseFloat(f.size);
   }
-  const netCostUsdc = feesUsdc - fundingUsd;
 
   return {
-    fills: allFills.length,
+    fills: takers.length,
     feesUsdc,
-    fundingUsd,
-    netCostUsdc,
+    fundingUsd: 0,
+    netCostUsdc: feesUsdc,
     notionalUsd,
     avgFeeRateBps: notionalUsd > 0 ? (feesUsdc / notionalUsd) * 10000 : 0,
   };
@@ -540,7 +523,7 @@ async function fetchGainsTrades(wallet: string, cutoffMs: number): Promise<Gains
   const all: GainsApiTrade[] = [];
   let cursor: number | undefined;
   let pages = 0;
-  const MAX_PAGES = 10;
+  const MAX_PAGES = 6;
 
   do {
     const params = new URLSearchParams({ chainId: "42161", limit: "100", startDate });
diff --git a/src/components/fee-compare-client.tsx b/src/components/fee-compare-client.tsx
index 63ba9844..5d957e3f 100644
--- a/src/components/fee-compare-client.tsx
+++ b/src/components/fee-compare-client.tsx
@@ -1257,8 +1257,7 @@ function Footnote({ venueA, venueB }: { venueA: VenueResult; venueB: VenueResult
       )}
       {hasDydx && (
         <>
-          dYdX v4: public indexer with full pagination and date filter. Funding from{" "}
-          <code className="font-mono text-[10px]">perpetualPositions.netFunding</code>. Address must be{" "}
+          dYdX v4: public indexer with full pagination and date filter. Taker fills only. Funding excluded (not date-scopable from public API). Address must be{" "}
           <code className="font-mono text-[10px]">dydx1...</code> Cosmos format.{" "}
         </>
       )}