From dd8059f87276192bd7e64fc7de5d6eea3b0a433b Mon Sep 17 00:00:00 2001
From: Chen Kai <281165273grape@gmail.com>
Date: Mon, 10 Aug 2026 18:13:09 +0800
Subject: [PATCH] fix: avoid double free in external typed array creation

---
 src/js/typed_arrays.zig | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/js/typed_arrays.zig b/src/js/typed_arrays.zig
index c1f0d0f..6684142 100644
--- a/src/js/typed_arrays.zig
+++ b/src/js/typed_arrays.zig
@@ -78,7 +78,15 @@ pub fn TypedArray(comptime Element: type, comptime array_type: TypedarrayType) t
             const len_hint: ?*anyopaque = @ptrFromInt(slice.len);
             const finalize_cb = comptime napi.wrapSliceFinalizeCallback(Element, externalFinalizer);
             const arraybuffer = e.createExternalArrayBuffer(std.mem.sliceAsBytes(buf), finalize_cb, len_hint) catch |err| {
-                context.allocator().free(buf);
+                // These statuses are returned before N-API installs the finalizer.
+                switch (err) {
+                    error.NoExternalBuffersAllowed,
+                    error.PendingException,
+                    error.CannotRunJS,
+                    => context.allocator().free(buf),
+                    // Other failures may occur after the finalizer has taken ownership.
+                    else => {},
+                }
                 return err;
             };