Skip to content

Risky findings print 0 B, hiding how big the file actually is #100

Description

@Muawiya-contact

Every finding under Risky — not recommended prints 0 B, because the row shows reclaimable, and reclaimable is deliberately zero for anything nothing will offer to move:

Risky — not recommended — 2 findings · 0 B
  Build artifacts · 2 · 0 B
          0 B  ~/projects/dashboard/node_modules/react/index.js
               matched rule node-modules: Regenerable via npm install.
               referenced by 1 project

The zero is correct — keeping risky bytes out of the headline is the behaviour is_actionable in report.rs exists to guarantee, and it shouldn't change. But as a row in a list of files, 0 B reads as a bug or an empty file, and it hides the one number the user actually wants: how big is the thing I'm being told not to touch.

A 4 GB node_modules that three projects depend on and a 2 KB one look identical here.

Suggestion: show the file's real size on the row, and let the group subtotal keep carrying the reclaimable zero — the "Risky" heading already tells the user nothing here is on offer. Something like:

  Build artifacts · 2 · 0 B reclaimable
        604.0 MB  ~/projects/dashboard/node_modules/react/index.js

Worth deciding the wording before implementing; the constraint is that no reader should come away thinking risky bytes count toward the reclaimable total.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    clidiskern-cli: the terminal frontendenhancementNew feature or requestlevel: beginnerSmall and well-scoped; no deep context neededpriority: lowNice to haveui/uxInterface design, usability, and visual polish

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions