Skip to content

dashmap is a dependency of diskern-core and is never used #86

Description

@Muawiya-contact

diskern-core depends on dashmap and never mentions it:

$ grep -rn "dashmap\|DashMap" crates app --include=*.rs
$ 

It is declared in the root [workspace.dependencies] and taken in
crates/diskern-core/Cargo.toml, so it is compiled into every build of
the engine — it shows up in the build log right beside the crates the
engine actually uses:

Checking petgraph v0.8.3
Checking dashmap v6.2.1
Checking getrandom v0.4.3

Presumably left over from an earlier plan for the parallel walk, which
ended up with jwalk collecting into a Vec and rayon for the hashing.

The fix is to drop the line from crates/diskern-core/Cargo.toml and the
entry from the workspace table, then confirm
cargo test -p diskern-core -p diskern-cli still passes. An unused
dependency is build time and audit surface for nothing — the audit
ignore-list in .cargo/audit.toml is already long enough with the ones
Tauri forces on us.

crates/diskern-core/Cargo.toml:24 · Cargo.toml:31

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance, cleanup, toolinggood first issueGood for newcomerslevel: beginnerSmall and well-scoped; no deep context neededpriority: lowNice to haverustPull requests that update rust code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions