From a92855801b7d36a93b2914626f042192adde67fa Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Fri, 28 Aug 2026 14:47:57 +1200 Subject: [PATCH 1/8] tweaks to NotebookManagementTools.jl --- NotebookManagementTools/src/generate.jl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/NotebookManagementTools/src/generate.jl b/NotebookManagementTools/src/generate.jl index 5ba4aac..931d85e 100644 --- a/NotebookManagementTools/src/generate.jl +++ b/NotebookManagementTools/src/generate.jl @@ -59,9 +59,13 @@ function generate( # fencing: literate_config = "codefence" => Pair("````@julia", "````" ) - # Note the use of '$ ⋯ ' to interpolate into a Julia command. Naive use of - # $ doesn't work. - cmd = `julia + # get julia minor version: + version = join(split(string(VERSION), ".")[1:2], ".") + + # Note the use of '$ ⋯ ' to interpolate into a Julia code execution block. Naive use + # of $ doesn't work. + + cmd = `julia +$version --startup-file=no --color=yes --project=$notebook_dir -e ' @@ -92,13 +96,14 @@ function generate( using Literate if '$testing' + @info "Testing '$name'." @testset "'$name'" begin include("'$test_file'") @test true end end - @info "Generating markdown for '$name'... " + @info "Generating markdown for '$name'." Literate.markdown( "'$script_file'", From 44ebf1644227244c38133b2fa184431e7c7b622b Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Fri, 28 Aug 2026 15:11:24 +1200 Subject: [PATCH 2/8] tweak NotebookManagementTools --- NotebookManagementTools/src/generate.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NotebookManagementTools/src/generate.jl b/NotebookManagementTools/src/generate.jl index 931d85e..0facfef 100644 --- a/NotebookManagementTools/src/generate.jl +++ b/NotebookManagementTools/src/generate.jl @@ -59,8 +59,8 @@ function generate( # fencing: literate_config = "codefence" => Pair("````@julia", "````" ) - # get julia minor version: - version = join(split(string(VERSION), ".")[1:2], ".") + # get julia version to spawn: + version = string(VERSION) # Note the use of '$ ⋯ ' to interpolate into a Julia code execution block. Naive use # of $ doesn't work. From 02215a56e37bdffb81dbd64d277f40ac85c60f9b Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Fri, 28 Aug 2026 15:12:21 +1200 Subject: [PATCH 3/8] trivial change to 99_solutions... to trigger markdown re-generation --- .../notebooks/MLJTutorial/99_solution_to_exercises/notebook.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/notebooks/MLJTutorial/99_solution_to_exercises/notebook.jl b/docs/src/notebooks/MLJTutorial/99_solution_to_exercises/notebook.jl index c089477..237fb8f 100644 --- a/docs/src/notebooks/MLJTutorial/99_solution_to_exercises/notebook.jl +++ b/docs/src/notebooks/MLJTutorial/99_solution_to_exercises/notebook.jl @@ -70,7 +70,7 @@ scitype(v[1:2]) # #### Exercise 2 solution -# From the question statement: +# From the question statement, we have: quality = ["good", "poor", "poor", "excellent", missing, "good", "excellent"] From 082fc97ca8bacf775e652cb8e925fc6d5ac20042 Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Fri, 28 Aug 2026 23:51:16 +1200 Subject: [PATCH 4/8] temporarily omit julia version in generate.jl command --- NotebookManagementTools/src/generate.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NotebookManagementTools/src/generate.jl b/NotebookManagementTools/src/generate.jl index 0facfef..f141c3b 100644 --- a/NotebookManagementTools/src/generate.jl +++ b/NotebookManagementTools/src/generate.jl @@ -65,7 +65,7 @@ function generate( # Note the use of '$ ⋯ ' to interpolate into a Julia code execution block. Naive use # of $ doesn't work. - cmd = `julia +$version + cmd = `julia --startup-file=no --color=yes --project=$notebook_dir -e ' From 5cfad89975d4b0f427d0ddaca37853845efc80bf Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Sat, 29 Aug 2026 06:40:52 +1200 Subject: [PATCH 5/8] delete filter on what new files from notebooks CI should commit --- .github/workflows/generate_notebooks.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/generate_notebooks.yml b/.github/workflows/generate_notebooks.yml index 8dbc84e..a2e1b4c 100644 --- a/.github/workflows/generate_notebooks.yml +++ b/.github/workflows/generate_notebooks.yml @@ -100,8 +100,6 @@ jobs: added to the parent pull request, \#${{ github.event.pull_request.number }}. delete-branch: true - add-paths: | - **/notebook.md - name: Post comment flagging further action required if: steps.spawn_pr.outputs.pull-request-operation == 'created' From ef71dbfbcdae40fdec3074cf6622a3080f676166 Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Sat, 29 Aug 2026 06:44:32 +1200 Subject: [PATCH 6/8] tweak generate again --- NotebookManagementTools/src/generate.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NotebookManagementTools/src/generate.jl b/NotebookManagementTools/src/generate.jl index f141c3b..09db95b 100644 --- a/NotebookManagementTools/src/generate.jl +++ b/NotebookManagementTools/src/generate.jl @@ -59,13 +59,13 @@ function generate( # fencing: literate_config = "codefence" => Pair("````@julia", "````" ) - # get julia version to spawn: - version = string(VERSION) + # get minor julia version to spawn: + version = join(split(string(VERSION), ".")[1:2], ".")) # Note the use of '$ ⋯ ' to interpolate into a Julia code execution block. Naive use # of $ doesn't work. - cmd = `julia + cmd = `julia +$version --startup-file=no --color=yes --project=$notebook_dir -e ' From 5555b966b68becbcb2aa66778707b9231e2f20f1 Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Sat, 29 Aug 2026 14:23:08 +1200 Subject: [PATCH 7/8] teak again to fix syntax error --- NotebookManagementTools/src/generate.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NotebookManagementTools/src/generate.jl b/NotebookManagementTools/src/generate.jl index 09db95b..61a9fba 100644 --- a/NotebookManagementTools/src/generate.jl +++ b/NotebookManagementTools/src/generate.jl @@ -60,7 +60,7 @@ function generate( literate_config = "codefence" => Pair("````@julia", "````" ) # get minor julia version to spawn: - version = join(split(string(VERSION), ".")[1:2], ".")) + version = join(split(string(VERSION), ".")[1:2], ".") # Note the use of '$ ⋯ ' to interpolate into a Julia code execution block. Naive use # of $ doesn't work. From 0c3e2f1e4085233432ad9489f55cb39563052141 Mon Sep 17 00:00:00 2001 From: "Anthony D. Blaom" Date: Sat, 29 Aug 2026 14:48:16 +1200 Subject: [PATCH 8/8] drop attempt to ensure same version of julia is run --- NotebookManagementTools/src/generate.jl | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/NotebookManagementTools/src/generate.jl b/NotebookManagementTools/src/generate.jl index 61a9fba..df8efe3 100644 --- a/NotebookManagementTools/src/generate.jl +++ b/NotebookManagementTools/src/generate.jl @@ -59,13 +59,10 @@ function generate( # fencing: literate_config = "codefence" => Pair("````@julia", "````" ) - # get minor julia version to spawn: - version = join(split(string(VERSION), ".")[1:2], ".") - # Note the use of '$ ⋯ ' to interpolate into a Julia code execution block. Naive use # of $ doesn't work. - cmd = `julia +$version + cmd = `julia --startup-file=no --color=yes --project=$notebook_dir -e '