Skip to content

AutoApprove template parameter has no effect (no approval call ever made) #25

Description

@spbsoluble

Symptom

The AutoApprove enrollment parameter (Constants.EnrollmentParam.AutoApprove) is threaded through EnrollNewAsync/RenewOrReissueAsync into BuildEnrollmentResult(resp, autoApprove) at three call sites (CERTInextCAPlugin.cs:1189, 1205, 1330), but BuildEnrollmentResult's body never reads the autoApprove parameter — it's dead. There is no approval-style endpoint anywhere in Constants.Api, and no code path ever calls CERTInext to approve a pending order.

Both the plugin's own connector UI text (CERTInextCAPluginConfig.cs:447-448, "the gateway will attempt automatic approval...") and docsource/configuration.md described behavior that doesn't exist in the code. The docs have been corrected to say this is currently a no-op; the UI text in CERTInextCAPluginConfig.cs still says otherwise and should be fixed together with (or ahead of) actually implementing the behavior.

How this was found

Found during a docsource freshness review (2026-08-13) while auditing configuration.md against current code.

Severity

Low/Medium — a template setting silently does nothing, which is confusing but not a functional regression (nothing regressed; it likely never worked).

Fix

Not fixed here. Either implement an actual approval call (if CERTInext exposes one) or remove the parameter/UI text so it stops implying behavior that doesn't exist.

Files

  • CERTInext/CERTInextCAPlugin.cs:1189, 1205, 1330, 2330-2379 (BuildEnrollmentResult)
  • CERTInext/CERTInextCAPluginConfig.cs:445-452 (misleading UI Comments text)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions