From 6d6bb8fecbf07ac3030b6a4d6912ab05ab59e38b Mon Sep 17 00:00:00 2001 From: jallentxbiomed Date: Fri, 7 Aug 2026 10:35:47 -0500 Subject: [PATCH 1/2] updated view definition for attribute delete ETL --- .../source_queries/create_v_delete_snd_attributeData.sql | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql b/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql index a05a55707..7becfe212 100644 --- a/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql +++ b/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql @@ -21,6 +21,9 @@ CREATE VIEW [labkey_etl].[v_delete_snd_attributeData] AS -- Note: -- -- Changes: +-- Jay Allen - Only propagate a delete if the kew no longer exists in the source. EventDataAndName +-- is not unique when CAMP holds duplicate attribute rows, so cleaning up duplicate +-- caused ETL to delete the legitimate value from exp.ObjectProperty -- -- ========================================================================================== @@ -29,6 +32,12 @@ SELECT a.audit_date_tm FROM audit.audit_coded_proc_attribs AS a WHERE a.audit_action = 'D' + AND NOT EXISTS ( + SELECT 1 + FROM dbo.CODED_PROC_ATTRIBS cpa + WHERE cpa.PROC_ID = a.PROC_ID + AND cpa.ATTRIB_KEY = a.ATTRIB_KEY + ) GO GRANT SELECT on labkey_etl.v_delete_snd_AttributeData to z_labkey From 91186baa8327d630f3fd26bab9640449dccf78af Mon Sep 17 00:00:00 2001 From: jallentxbiomed Date: Fri, 7 Aug 2026 11:47:45 -0500 Subject: [PATCH 2/2] updated comment --- .../source_queries/create_v_delete_snd_attributeData.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql b/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql index 7becfe212..c7d01c993 100644 --- a/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql +++ b/snprc_ehr/resources/source_queries/create_v_delete_snd_attributeData.sql @@ -22,8 +22,8 @@ CREATE VIEW [labkey_etl].[v_delete_snd_attributeData] AS -- -- Changes: -- Jay Allen - Only propagate a delete if the kew no longer exists in the source. EventDataAndName --- is not unique when CAMP holds duplicate attribute rows, so cleaning up duplicate --- caused ETL to delete the legitimate value from exp.ObjectProperty +-- (PROC_ID + ATTRIB_KEY) is not unique when CAMP holds duplicate attribute rows, +-- so cleaning up duplicate caused ETL to delete the legitimate value from exp.ObjectProperty -- -- ==========================================================================================