From 0d3899c782998c5750338dc11beea569207cb26c Mon Sep 17 00:00:00 2001
From: Lukas Gold <lukas.gold@isc.fraunhofer.de>
Date: Mon, 31 Aug 2026 17:25:59 +0200
Subject: [PATCH] feat(wtsite): allow an edit comment on upload_page

- add comment field to WtSite.UploadPageParam
- forward it to WtPage.edit, which already accepted one
- closes #112
---
 src/osw/wtsite.py                |  4 ++-
 tests/test_wtsite_upload_page.py | 60 ++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 1 deletion(-)
 create mode 100644 tests/test_wtsite_upload_page.py

diff --git a/src/osw/wtsite.py b/src/osw/wtsite.py
index 2c49b78..3720e2a 100644
--- a/src/osw/wtsite.py
+++ b/src/osw/wtsite.py
@@ -624,6 +624,8 @@ class UploadPageParam(OswBaseModel):
         """If True, uploads the pages in parallel."""
         debug: Optional[bool] = False
         """If True, debug messages will be printed."""
+        comment: Optional[str] = None
+        """Edit comment for the page history, applied to every uploaded page."""
 
         class Config:
             arbitrary_types_allowed = True
@@ -663,7 +665,7 @@ def upload_page_(page, index: int = None):
                     f"WtSite from which this method is called from "
                     f"are not matching!"
                 )
-            page.edit()
+            page.edit(param.comment)
 
             if index is None:
                 print(f"Uploaded page to {page.get_url()}.")
diff --git a/tests/test_wtsite_upload_page.py b/tests/test_wtsite_upload_page.py
new file mode 100644
index 0000000..730a1ba
--- /dev/null
+++ b/tests/test_wtsite_upload_page.py
@@ -0,0 +1,60 @@
+"""Unit tests for WtSite.upload_page().
+
+Regression guard for #112: an edit comment supplied via UploadPageParam must
+reach WtPage.edit(), so bulk uploads are attributable in the page history.
+"""
+
+import threading
+
+from osw.wtsite import WtPage, WtSite
+
+
+class _FakeSite:
+    """Stands in for mwclient.Site, only get_url() touches it."""
+
+    host = "example.org"
+
+
+def _make_fake_wtsite():
+    """A WtSite that performs no network calls."""
+    ws = WtSite.__new__(WtSite)
+    ws._session_lock = threading.RLock()
+    ws._site = _FakeSite()
+    return ws
+
+
+def _make_page(wtsite, title, recorder, monkeypatch):
+    page = WtPage(wtSite=wtsite, title=title, do_init=False)
+    monkeypatch.setattr(page, "edit", lambda comment=None: recorder.append(comment))
+    return page
+
+
+def test_upload_page_forwards_comment(monkeypatch):
+    ws = _make_fake_wtsite()
+    comments = []
+    page = _make_page(ws, "Item:OSW123", comments, monkeypatch)
+
+    ws.upload_page(WtSite.UploadPageParam(pages=page, comment="[bot edit] import"))
+
+    assert comments == ["[bot edit] import"]
+
+
+def test_upload_page_forwards_comment_to_every_page(monkeypatch):
+    ws = _make_fake_wtsite()
+    comments = []
+    pages = [_make_page(ws, f"Item:OSW{i}", comments, monkeypatch) for i in range(3)]
+
+    ws.upload_page(WtSite.UploadPageParam(pages=pages, comment="same for all"))
+
+    assert comments == ["same for all"] * 3
+
+
+def test_upload_page_without_comment_passes_none(monkeypatch):
+    """Default behaviour is unchanged: edit() is called with no comment."""
+    ws = _make_fake_wtsite()
+    comments = []
+    page = _make_page(ws, "Item:OSW123", comments, monkeypatch)
+
+    ws.upload_page(page)
+
+    assert comments == [None]