Skip to content

Commit f7d5ab0

Browse files
leliaclaude
andcommitted
Drop ticket references from e2e comments and note the retry hardening in the changelog
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
1 parent 8141b48 commit f7d5ab0

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

.github/workflows/e2e-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ jobs:
4747
validate: tests/e2e/validate-reachability.sh
4848
setup-node: "true"
4949
# The tier-1 reachability backend intermittently returns empty
50-
# results while the CLI reports success (ENG-5093). The probe
51-
# exits 0 when the facts file has alerted components; anything
52-
# else is retried before validation fails the job.
50+
# results while the CLI reports success. The probe exits 0 when
51+
# the facts file has alerted components; anything else is
52+
# retried before validation fails the job.
5353
retry-probe: bash tests/e2e/reach-facts-probe.sh tests/e2e/fixtures/simple-npm
5454

5555
- name: gitlab
@@ -123,7 +123,7 @@ jobs:
123123
echo "::warning title=e2e-${{ matrix.name }} incomplete results::output still fails the completeness probe after ${max_attempts} attempts; letting validation fail the job"
124124
break
125125
fi
126-
echo "::warning title=e2e-${{ matrix.name }} transient retry::attempt ${attempt} failed the completeness probe (suspected backend transient, see ENG-5093); retrying"
126+
echo "::warning title=e2e-${{ matrix.name }} transient retry::attempt ${attempt} failed the completeness probe (suspected backend transient); retrying"
127127
echo "e2e-${{ matrix.name }}: retry after attempt ${attempt} — completeness probe failed (suspected transient)" >> "$GITHUB_STEP_SUMMARY"
128128
attempt=$((attempt+1))
129129
sleep 30

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@
1212
(e.g. `generic`) and skips individual unparseable artifacts in the stream
1313
instead of failing the whole response.
1414

15+
### Changed: e2e reachability jobs retry transient empty results
16+
17+
- The e2e workflow now detects reachability runs that report success with no
18+
alerted components in the facts file — a transient backend condition — and
19+
retries the scan up to three times, uploading run artifacts on failure.
20+
1521
## 2.5.9
1622

1723
### Changed: bump pinned @coana-tech/cli to 15.10.3

tests/e2e/reach-facts-probe.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
#
44
# Used by the e2e workflow's retry-probe hook: a --reach run against the
55
# known-vulnerable fixture that reports success but yields no alerted
6-
# components is the signature of a transient tier-1 backend failure
7-
# (ENG-5093), so the run is worth repeating before validation fails the job.
6+
# components is the signature of a transient tier-1 backend failure,
7+
# so the run is worth repeating before validation fails the job.
88
set -euo pipefail
99

1010
TARGET="${1:?usage: reach-facts-probe.sh <target-path>}"

0 commit comments

Comments
 (0)