From 3ad150450379fc0088e8ffae4b522cc878c0969f Mon Sep 17 00:00:00 2001
From: caviri <45425937+caviri@users.noreply.github.com>
Date: Wed, 19 Aug 2026 00:15:32 +0200
Subject: [PATCH 1/3] fix(frontend): stop saving voting rules from silently
 unchecking own-team
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Rules form used a bare `use:enhance`, whose default success handler calls
form.reset(). `checked={data.policy.ownTeamVoting}` sets the checkbox PROPERTY,
never the defaultChecked ATTRIBUTE, so reset reverts every box to unchecked.
`ownTeamVoting` defaults to checked and round-trips to the same value, so
Svelte's fine-grained reactivity never re-asserts the property — the reset's
uncheck sticks and the save looks like it turned the rule off. The data was
saved correctly; only the display lied, and a second save from that state would
have stored the false the organiser never chose.

Uses the file's existing `keepValues` handler (update({ reset: false })), which
keeps the invalidation that reflects genuine changes while dropping the
destructive reset.
---
 .../(app)/my/hackathon/[id]/voting/+page.svelte      | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.svelte b/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.svelte
index 96bf0e60..dcb4737e 100644
--- a/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.svelte
+++ b/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.svelte
@@ -125,8 +125,16 @@
             <!-- The rules of the vote. They were stored and never read on the
                  server, and never written from anywhere at all — an event could
                  not state its own rules. Prefilled, because SetVotingPolicy
-                 replaces the whole record. -->
-            <form method="POST" action="?/setPolicy" use:enhance class="card flex flex-col gap-3 p-4">
+                 replaces the whole record.
+
+                 keepValues, not a bare use:enhance: checked={…} sets the
+                 checkbox PROPERTY, never the defaultChecked attribute, so the
+                 default form.reset() after a successful save reverts the boxes
+                 to unchecked. ownTeamVoting defaults to checked and round-trips
+                 to the same value, so Svelte's reactivity never re-asserts it —
+                 the reset's uncheck sticks, and saving looks like it silently
+                 turned the rule off. -->
+            <form method="POST" action="?/setPolicy" use:enhance={keepValues} class="card flex flex-col gap-3 p-4">
                 <h2 class="m-0 text-xl font-bold">Rules</h2>
 
                 <label class="flex items-start gap-2 text-sm">

From a1d26007ff9c266a8ac972dd6c8ac001926b7080 Mon Sep 17 00:00:00 2001
From: caviri <45425937+caviri@users.noreply.github.com>
Date: Wed, 19 Aug 2026 00:15:33 +0200
Subject: [PATCH 2/3] fix(frontend): tell a voter why a ballot was refused
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

castBallot mapped every FAILED_PRECONDITION to one string, "Voting is not open
for this hackathon." SubmitVote answers that code for two distinct states — the
votingEnabled master switch being off, and the VOTE capability being closed by
the current phase — so an organiser was told voting was closed with no way to
know which of the two separate controls to fix. Surface the server's own detail
(the same `e.details || "…"` pattern this file already uses for other codes).
---
 .../(app)/my/hackathon/[id]/voting/+page.server.ts       | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.server.ts b/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.server.ts
index 30072b8c..8b2c2981 100644
--- a/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.server.ts
+++ b/components/frontend/src/routes/(app)/my/hackathon/[id]/voting/+page.server.ts
@@ -579,7 +579,14 @@ export const actions: Actions = {
         })
       }
       if (e instanceof ClientError && e.code === Status.FAILED_PRECONDITION) {
-        return bad(409, { message: "Voting is not open for this hackathon." })
+        // Surface the server's specific reason. SubmitVote answers
+        // FAILED_PRECONDITION for two distinct states — the votingEnabled
+        // master switch being off ("voting is closed") and the VOTE capability
+        // being closed by the current phase (capabilityClosedMessage) — and one
+        // hardcoded string cannot tell an organiser which of the two to fix.
+        return bad(409, {
+          message: e.details || "Voting is not open for this hackathon.",
+        })
       }
       return formError(e)
     }

From 217556df35f9847ac76faaa67015ebb84039081a Mon Sep 17 00:00:00 2001
From: caviri <45425937+caviri@users.noreply.github.com>
Date: Wed, 19 Aug 2026 00:20:28 +0200
Subject: [PATCH 3/3] fix(frontend): stop the teams "More Information" link
 from erroring
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

TeamCard resolves its moreInfoHref through SvelteKit's resolve(), which takes a
route id. The teams list passed "#team-{id}" — a bare fragment, cast to `any`
to get past the type checker — and resolve() throws on it, so clicking "More
Information" errored. There is also no element with that id to scroll to: main's
teams/[teamId] detail page was not carried onto this branch, so the fragment
never had a target.

Guard the link on a real in-app route (moreInfoHref.startsWith("/")) and stop
the teams page passing a fragment, so the dead link is not offered until a team
detail page exists to point at. ProjectCard's callers pass real routes and are
unaffected.
---
 .../src/lib/components/hackathon/TeamCard.svelte  | 15 +++++++++++----
 .../(app)/my/hackathon/[id]/teams/+page.svelte    |  5 ++++-
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/components/frontend/src/lib/components/hackathon/TeamCard.svelte b/components/frontend/src/lib/components/hackathon/TeamCard.svelte
index 14ac4a37..e1bb6d27 100644
--- a/components/frontend/src/lib/components/hackathon/TeamCard.svelte
+++ b/components/frontend/src/lib/components/hackathon/TeamCard.svelte
@@ -125,9 +125,16 @@
             </button>
         {/if}
 
-        <!-- eslint-disable-next-line @typescript-eslint/no-explicit-any -- dynamic path from page data; resolve() is route-literal typed -->
-        <a href={resolve(moreInfoHref as any)} class="btn btn-sm btn-ghost">
-            More Information
-        </a>
+        <!-- Only a real in-app route can be resolved; a placeholder '#' or a
+             bare '#fragment' throws inside resolve(). Teams have no detail page
+             on this branch (main's teams/[teamId] was not carried over), so the
+             list passes a fragment and this used to error on click. Offer no
+             dead link until there is somewhere to point. -->
+        {#if moreInfoHref.startsWith('/')}
+            <!-- eslint-disable-next-line @typescript-eslint/no-explicit-any -- dynamic path from page data; resolve() is route-literal typed -->
+            <a href={resolve(moreInfoHref as any)} class="btn btn-sm btn-ghost">
+                More Information
+            </a>
+        {/if}
     </div>
 </div>
diff --git a/components/frontend/src/routes/(app)/my/hackathon/[id]/teams/+page.svelte b/components/frontend/src/routes/(app)/my/hackathon/[id]/teams/+page.svelte
index 0f0bff1b..2c420789 100644
--- a/components/frontend/src/routes/(app)/my/hackathon/[id]/teams/+page.svelte
+++ b/components/frontend/src/routes/(app)/my/hackathon/[id]/teams/+page.svelte
@@ -84,6 +84,10 @@
             </p>
         {:else}
             {#each pagedTeams as team (team.id)}
+                <!-- No moreInfoHref: teams have no detail page on this branch
+                     (main's teams/[teamId] was not carried over), and the
+                     placeholder "#team-{id}" this used to pass threw inside
+                     TeamCard's resolve(). TeamCard hides the link without one. -->
                 <TeamCard
                     num={team.num}
                     title={team.title}
@@ -91,7 +95,6 @@
                     imageUrl={team.imageUrl}
                     members={team.members}
                     isOwn={team.isOwn}
-                    moreInfoHref="#team-{team.id}"
                 />
             {/each}
         {/if}