I haven't been able to compile and test your version, but Magicspells has always suffered from a pretty severe problem with dynamically adding/removing spells with permissions.
If you add a spell with magicspells.grant.spellname and cast.spellname, if you revoke those permissions the player is still able to cast the spells until they relog or you execute /cast reload as an admin.
I believe that permissions should be re-checked at spell cast, at spell selection via item, and at any /cast command, and non-granted/unknown spells should be purged from the characters spell list.
Also, an option to disable spellbook saving/loading would be nice.
I haven't been able to compile and test your version, but Magicspells has always suffered from a pretty severe problem with dynamically adding/removing spells with permissions.
If you add a spell with magicspells.grant.spellname and cast.spellname, if you revoke those permissions the player is still able to cast the spells until they relog or you execute /cast reload as an admin.
I believe that permissions should be re-checked at spell cast, at spell selection via item, and at any /cast command, and non-granted/unknown spells should be purged from the characters spell list.
Also, an option to disable spellbook saving/loading would be nice.