Skip to content

Make the version check configurable #566

Description

@dr-goo

Is your feature request related to a problem? Please describe.
_warn_user_if_sdk_version_outdated() hits https://pypi.python.org/pypi/vortexasdk/json on every create_client(), and the URL is hardcoded. On corporate machines public PyPI may be blocked and proxied through an internal mirror, so this check fails (or trips egress alerts) on every run.

Describe the solution you'd like
A way to point the version check at an internal mirror, or turn it off. Artifactory/Nexus proxies serve the same /pypi/<pkg>/json, so redirecting it returns identical data and the feature keeps working — just without public egress (verified against our internal Artifactory mirror: same release list and latest version as pypi.org).

Env vars are probably the most practical, since the check runs on the implicit default_client() path where there's nowhere to pass arguments:

  • VORTEXASDK_PYPI_URL — base URL for the check
  • VORTEXASDK_DISABLE_VERSION_CHECK — skip it entirely

Describe alternatives you've considered

  • Params on create_client() (e.g. pypi_url=, check_version=False) — cleaner API, but only helps callers who invoke it directly; most usage likely goes through default_client().

Additional context
#126 (which introduced the check) originally called for a toggle to turn the check on/off, but #198 shipped without one.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions