Skip to content

Unquote splicing example issue #10

Description

@kxygk

In Chapter 8, when explaining unquote splicing you change the macro arguments from 2 arguments to using a map and keywords. The example that follows is then incorrect (and doesn't run in my REPL)
https://github.com/braveclojure/cftbat-code/blob/master/08/code.clj#L231

This line should read instead
(code-critic {:good (1 + 1) :bad (+ 1 1)})

As far as I understand the argument change is unrelated to the unquote splicing and just makes things more confusing. Please correct me if I'm wrong :)

Thanks for the great book. I'm enjoying it a lot

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions