Your library seems very promising, but I thought I would let you know a few ideas I had while looking at it:
- Would be really great to get https support
- I'd request to avoid the use of C++ exceptions. Many C++ devs don't use them very much (they're notoriously expensive!)
- The single header, although it looks "easier to use" at first, is really difficult to browse. Splitting the source file into multiple files is almost always the best idea.
- style nit: I feel like you're overusing
auto in the code. I mean, in this case, int is shorter ;) The general guideline I've heard is to use auto where it "increases readability", very subjective :)
- There is some extra data copy that could be avoided. Consider going to C-arrays/
memcpy for passing around some of the data?
- Would be nice to have an
asyncSend that accepts a lambda onComplete handler (something like std::function<void (Response)>)
Your library seems very promising, but I thought I would let you know a few ideas I had while looking at it:
autoin the code. I mean, in this case,intis shorter ;) The general guideline I've heard is to useautowhere it "increases readability", very subjective :)memcpyfor passing around some of the data?asyncSendthat accepts a lambda onComplete handler (something likestd::function<void (Response)>)