Skip to content

Commit 7675866

Browse files
notartomstephenfin
andcommitted
Support compute microversion 2.94
The only thing that changes in 2.94 is server-side validation of the ``hostname`` parameter, so strictly speaking no client-side changes are needed. We can still improve the help text for --hostname to explain the differences between microversions, and add a functional test to exercise the new microversion. Change-Id: Id1049965150c46fe972733d6194b78d996c6e5d3 Signed-off-by: Artom Lifshitz <alifshit@redhat.com> Co-authored-by: Stephen Finucane <stephenfin@redhat.com>
1 parent 0933bda commit 7675866

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

openstackclient/compute/v2/server.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1563,8 +1563,10 @@ def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
15631563
'If unset, a hostname will be automatically generated from '
15641564
'the server name. '
15651565
'A utility such as cloud-init is required to propagate the '
1566-
'hostname in the metadata service to the guest OS itself. '
1567-
'(supported by --os-compute-api-version 2.90 or above)'
1566+
'hostname in the metadata service to the guest OS itself '
1567+
'(hostnames supported by --os-compute-api-version 2.90 or '
1568+
'above, FQDNs supported by --os-compute-api-version 2.94 or '
1569+
'above)'
15681570
),
15691571
)
15701572
parser.add_argument(
@@ -3676,8 +3678,10 @@ def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
36763678
help=_(
36773679
'Hostname configured for the server in the metadata service. '
36783680
'A separate utility running in the guest is required to '
3679-
'propagate changes to this value to the guest OS itself. '
3680-
'(supported by --os-compute-api-version 2.90 or above)'
3681+
'propagate changes to this value to the guest OS itself '
3682+
'(hostnames supported by --os-compute-api-version 2.90 or '
3683+
'above, FQDNs supported by --os-compute-api-version 2.94 or '
3684+
'above)'
36813685
),
36823686
)
36833687
parser.add_argument(
@@ -4673,8 +4677,10 @@ def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
46734677
help=_(
46744678
'Hostname configured for the server in the metadata service. '
46754679
'A separate utility running in the guest is required to '
4676-
'propagate changes to this value to the guest OS itself. '
4677-
'(supported by --os-compute-api-version 2.90 or above)'
4680+
'propagate changes to this value to the guest OS itself '
4681+
'(hostnames supported by --os-compute-api-version 2.90 or '
4682+
'above, FQDNs supported by --os-compute-api-version 2.94 or '
4683+
'above)'
46784684
),
46794685
)
46804686
return parser

0 commit comments

Comments
 (0)