Docs refer to removed systemd-units/kubernetes flags

[hardys]

The docs agent release e.g here resolves to v0.10.0-rc.1, but that release drops support for the --systemd-units flag since parca-dev/parca-agent#627 removed it.

$ grep -R systemd-units
docs/agent-binary.mdx:sudo parca-agent --node=systemd-test --systemd-units=docker.service --log-level=debug --kubernetes=false --store-address=localhost:7070 --insecure
docs/parca-agent-systemd.mdx:      --systemd-units=SYSTEMD-UNITS,...
docs/parca-agent-systemd.mdx:To profile units, you just need to specify the name of the service in `--systemd-units` flag.
docs/parca-agent-systemd.mdx:+  --systemd-units=docker.service,my-app.service \
docs/systemd.mdx:ExecStart=/usr/bin/parca-agent --http-address=":7071" --node=systemd-test --systemd-units=docker.service,parca.service,parca-agent.service --kubernetes=false --store-address=localhost:7070 --insecure
src/components/HomepageQuickstart.js:./parca-agent --node=systemd-test --systemd-units=parca-agent.service --kubernetes=false`

It also looks like --kubernetes=false is no longer valid - should these both just be removed?

[hardys]

Running as described at https://github.com/parca-dev/parca-agent/blob/main/CONTRIBUTING.md#run-parca-agent also doesn't seem to work, seems it's creating a kubernetes client - is local non-kube usage still supported?

level=debug name=parca-agent ts=2022-11-22T12:03:58.763762162Z caller=discovery_manager.go:310 msg="cannot create service discovery" err="create kubernetes client: get node test: Get \"https://127.0.0.1:40549/api/v1/nodes/test\": dial tcp 127.0.0.1:40549: connect: connection refused" type=test
level=debug name=parca-agent ts=2022-11-22T12:03:58.763794737Z caller=discovery_manager.go:186 msg="starting provider" provider=systemd/0 subs=[all]
level=debug name=parca-agent ts=2022-11-22T12:03:58.764218336Z caller=main.go:252 msg="starting: batch write client"
level=debug name=parca-agent ts=2022-11-22T12:03:58.764233155Z caller=main.go:511 msg="starting: profiler" name=parca_agent_cpu
level=debug name=parca-agent ts=2022-11-22T12:03:58.764236998Z caller=main.go:533 msg="starting: http server"
level=debug name=parca-agent ts=2022-11-22T12:03:58.764259973Z caller=cpu.go:190 msg="starting cpu profiler"
level=debug name=parca-agent ts=2022-11-22T12:03:58.76428957Z caller=main.go:295 msg="starting: discovery manager"
level=debug name=parca-agent ts=2022-11-22T12:03:58.764313709Z caller=main.go:519 msg="profiler: stopped" err=null profiler=parca_agent_cpu
level=debug name=parca-agent ts=2022-11-22T12:03:58.764338058Z caller=main.go:260 msg="stopped: batch write client"
level=debug name=parca-agent ts=2022-11-22T12:03:58.764350011Z caller=main.go:541 msg="stopped: http server"
level=debug name=parca-agent ts=2022-11-22T12:03:58.764350479Z caller=main.go:303 msg="stopped: discovery manager"
level=warn name=parca-agent ts=2022-11-22T12:03:58.764374085Z caller=discovery_manager.go:195 msg="unable to start provider" provider=systemd/0 error="failed to connect to systemd D-Bus API, read unix @->/run/dbus/system_bus_socket: use of closed network connection"
level=error name=parca-agent ts=2022-11-22T12:03:58.764412491Z caller=main.go:157 err="bpf check: 3 errors occurred:\n\t* perf event program type not supported: errno 0\n\t* stack trace map type not supported: errno 0\n\t* hash map type not supported: errno 0\n\n"

[hardys]

Looks like this is part of #169 but I'm still not clear if local non-kube usage is expected to work now, any clarification or pointers welcome, thanks! :)

[metalmatze]

Good catch. Indeed, we're still working on making v0.10.0 the latest release. By the time this version gets released the docs should be updated. Right now the docs are still for v0.9.x.

[hardys]

Right now the docs are still for v0.9.x.

Thanks for clarifying! Note the code in the docs which generates e.g https://www.parca.dev/docs/systemd#setting-up-parca-agent is picking up v0.10.0-rc.1 already, so it's a little confusing :)

If there are any pointers in the meantime about how to use the 0.10/system-wide profiling on baremetal that would be welcome!

[kakkoyun]

Thanks for clarifying! Note the code in the docs which generates e.g https://www.parca.dev/docs/systemd#setting-up-parca-agent is picking up v0.10.0-rc.1 already, so it's a little confusing :)

I hadn't realized, this was picking pre-releases. We need to update the docs anyway. Feel free to update the existing flags. At the very least, we will be consistent.