From 05a29ce6be4cd1b4d7ed9df9e60bbdc6faa9edfd Mon Sep 17 00:00:00 2001 From: Akhil Byju Date: Sat, 27 Jun 2026 19:13:39 -0700 Subject: [PATCH 1/3] gh-151925: Clarify DictComp.value in ast docs --- Doc/library/ast.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Doc/library/ast.rst b/Doc/library/ast.rst index 4809fdb42bf3d77..c8d6af39246af81 100644 --- a/Doc/library/ast.rst +++ b/Doc/library/ast.rst @@ -806,6 +806,8 @@ Comprehensions List and set comprehensions, generator expressions, and dictionary comprehensions. ``elt`` (or ``key`` and ``value``) is a single node representing the part that will be evaluated for each item. + For dictionary comprehensions using unpacking, ``value`` is ``None``; for example, + ``{**item for item in items}`` ``generators`` is a list of :class:`comprehension` nodes. From ac22a1c561acfa7065467a1c52f0e5932bfe374b Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Wed, 5 Aug 2026 15:15:04 +0200 Subject: [PATCH 2/3] Apply suggestion --- Doc/library/ast.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Doc/library/ast.rst b/Doc/library/ast.rst index c8d6af39246af81..dc48b7eeb61f349 100644 --- a/Doc/library/ast.rst +++ b/Doc/library/ast.rst @@ -806,8 +806,9 @@ Comprehensions List and set comprehensions, generator expressions, and dictionary comprehensions. ``elt`` (or ``key`` and ``value``) is a single node representing the part that will be evaluated for each item. - For dictionary comprehensions using unpacking, ``value`` is ``None``; for example, - ``{**item for item in items}`` + For dictionary comprehensions using unpacking, for example + ``{**item for item in items}``, ``value`` is ``None``, + ``generators`` is a list of :class:`comprehension` nodes. From 90257760efee6bd5467b0474a3f077c0f8232d20 Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Wed, 5 Aug 2026 18:10:32 +0200 Subject: [PATCH 3/3] Use an editor, not GitHub suggestions --- Doc/library/ast.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/Doc/library/ast.rst b/Doc/library/ast.rst index dc48b7eeb61f349..a85026d85cd263f 100644 --- a/Doc/library/ast.rst +++ b/Doc/library/ast.rst @@ -808,8 +808,6 @@ Comprehensions representing the part that will be evaluated for each item. For dictionary comprehensions using unpacking, for example ``{**item for item in items}``, ``value`` is ``None``, - - ``generators`` is a list of :class:`comprehension` nodes. .. doctest::