Skip to content

ResultStreamer doesn't take inline:true into account for large data sets #88

Description

@jogoussard

ResultStreamer.java.txt
According to http://docs.qubole.com/en/latest/rest-api/command_api/view-command-results.html, a response can contain "inline": true while still having the results in S3. The simple inline test done in ResultStream#getResults needs to be expanded into:
boolean isInline = resultValue.isInline();
if (resultValue.getResult_location() != null && resultValue.getResult_location().size() > 0)
{
isInline = false;
}
if (isInline)
{
return new StringReader(resultValue.getResults());
}

    return readFromS3(resultValue.getResult_location());

I have a fix for this, but can't push my branch for review (not authorized) - file attached.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions