Put all 39 compile and 50 run .bat scripts under Windows CI, and fix what that found

windows-bat covered four demos. It now covers every one, in three phases:
compile all 39 compile_<demo>.bat; launch all 50 run_<demo>.bat with no
arguments, which proves each script's class name still resolves; then drive four
with real arguments and check their output.

Running the whole set for the first time turned up four faults, none of which
anything would ever have noticed:

1. Two scripts still compiled src\main\java\demos\*.java, a directory the
   package rename deleted. The earlier bulk repair rewrote
   src\main\java\demos\<name> and its pattern did not match the bare wildcard
   form, so compile_analyzescript.bat and compile_gettablecolumns.bat kept a
   path to nothing.

2. compile_analyzesp.bat in the nested sybase folder had a doubled path,
   analyzesp\sybase\sybase\Analyze_SP.java. That one is mine: the same bulk
   repair substituted the script's own directory for a prefix that was itself a
   prefix of it. It was the only instance; every .bat path is now checked
   against the filesystem.

3. Both run_columnImpact.bat named gudusoft.gsqlparser.demos.columnImpact,
   a package that stopped existing when ColumnImpact moved under
   antiSQLInjection. There are two ColumnImpact classes and each script now
   names its own. The dlineageBasic one was deleted: that class has no main(),
   so the script had never been able to run it -- before the rename it was
   reaching the other folder's class.

4. Seven demos could not compile at all, because these scripts hand javac only
   their own folder while the classes import across demos -- columnAnalyze and
   plannerAnalyze pull in ColumnImpact, visitors and sqltranslator pull in
   JoinConverter. Adding -sourcepath src\main\java to all 39 lets javac resolve
   the rest, which is what the Maven build does anyway.

Also deleted TGetTableColumn_notUsed.java. It duplicated myMetaDB, TInfoRecord
and SortIgnoreCase from the TGetTableColumn.java beside it, so it broke any
wildcard compile of that folder -- which is exactly how
compile_gettablecolumns.bat compiles it. pom.xml had excluded it for the same
reason; that exclusion is gone with it.

Every one of these was reproduced and verified locally against JDK 8, the
toolchain CI uses, by simulating each script's javac and java invocation:
39/39 compile, 50/50 launch.

mvn clean test: 144 tests, the same 3 known analyzespTest failures.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012qPRpoD8exYRrUmbfXXWXj

Author: 2 people

.github/workflows/build.yml

@@ -128,6 +128,57 @@ jobs:
           echo ::error::fetch-parser.bat produced no parser jar
           exit /b 1
 
+      # Phase 1: every compile_<demo>.bat must succeed. This is the check that
+      # matters, and the one that would have caught the whole family going stale
+      # when the demos moved directory. `pause` at the end of each script would
+      # block forever on a runner with no keyboard, so stdin is fed from NUL.
+      - name: Compile all 39 demos via compile_*.bat
+        shell: cmd
+        run: |
+          setlocal enabledelayedexpansion
+          set FAILED=0
+          set COUNT=0
+          for /r "%GITHUB_WORKSPACE%\src\main\java" %%s in (compile_*.bat) do (
+            set /a COUNT+=1
+            pushd "%%~dps"
+            call "%%~nxs" < NUL > "%GITHUB_WORKSPACE%\c.txt" 2>&1
+            findstr /i /c:"error" /c:"file not found" /c:"no source files" "%GITHUB_WORKSPACE%\c.txt" >NUL && (
+              echo ::error::%%~nxs failed
+              type "%GITHUB_WORKSPACE%\c.txt"
+              set /a FAILED+=1
+            ) || echo   ok  %%~nxs
+            popd
+          )
+          echo.
+          echo compiled !COUNT! demos, !FAILED! failed
+          if not !FAILED!==0 exit /b 1
+
+      # Phase 2: every run_<demo>.bat must at least start its class. Run with no
+      # arguments, so most print their own usage line; what this proves is that
+      # the class name in the script still resolves and the classpath is right.
+      # A stale class name after a package move shows up here as
+      # ClassNotFoundException, which is exactly what had happened.
+      - name: Launch all 50 demos via run_*.bat
+        shell: cmd
+        run: |
+          setlocal enabledelayedexpansion
+          set FAILED=0
+          set COUNT=0
+          for /r "%GITHUB_WORKSPACE%\src\main\java" %%s in (run_*.bat) do (
+            set /a COUNT+=1
+            pushd "%%~dps"
+            call "%%~nxs" < NUL > "%GITHUB_WORKSPACE%\r.txt" 2>&1
+            findstr /c:"ClassNotFoundException" /c:"NoClassDefFoundError" /c:"Main method not found" "%GITHUB_WORKSPACE%\r.txt" >NUL && (
+              echo ::error::%%~nxs could not launch its class
+              type "%GITHUB_WORKSPACE%\r.txt"
+              set /a FAILED+=1
+            ) || echo   ok  %%~nxs
+            popd
+          )
+          echo.
+          echo launched !COUNT! demos, !FAILED! failed
+          if not !FAILED!==0 exit /b 1
+
       # `pause` at the end of each script would block forever on a runner with
       # no keyboard, so stdin is fed from NUL.
       #
@@ -136,7 +187,9 @@ jobs:
       # directory deeper (so its cd depth differs). They are generated from one
       # template and go stale as a set, which is exactly what happened when the
       # demos moved directory, so this is a canary rather than full coverage.
-      - name: Run the .bat scripts
+      # Phase 3: a few demos driven with real arguments and checked against a
+      # string their output must contain, so this is not only a smoke test.
+      - name: Run four demos with real arguments
         shell: cmd
         run: |
           echo SELECT a.id FROM ta a; > "%GITHUB_WORKSPACE%\q.sql"

README.md

@@ -445,26 +445,35 @@ They had been stale for years — compiling `src\main\java\demos\<demo>\` and
 `cd`-ing up five levels, both correct only before the demos moved under
 `gudusoft/gsqlparser/demos/`. Nothing noticed, because nothing ran them.
 
-The `windows-bat` job in `.github/workflows/build.yml` now does, on
-`windows-latest`. It first asserts that **no parser jar is committed** and that
-`fetch-parser.bat` can bootstrap one, then compiles and runs four demos, each
-checked against a string its output must contain:
-
-| demo | shape it covers |
-|------|-----------------|
-| `checksyntax` | `/f <file> /t <vendor>` |
-| `formatsql` | bare filename |
-| `listGSPInfo` | no arguments at all |
-| `modifysql` | compile and run scripts named differently (`compile_modifysql.bat` builds the folder, `run_replaceTablename.bat` runs one class) |
+The `windows-bat` job in `.github/workflows/build.yml` runs them on
+`windows-latest`, in three phases:
+
+1. **Bootstrap** — assert no parser jar is committed, then let
+   `fetch-parser.bat` pull one into `external_lib/`.
+2. **Compile all 39** `compile_<demo>.bat`. This is the check that matters: it
+   is what would have caught the whole family going stale when the demos moved
+   directory.
+3. **Launch all 50** `run_<demo>.bat` with no arguments, so most print their own
+   usage line. What this proves is that each script's class name still resolves
+   — a stale name after a package move surfaces here as
+   `ClassNotFoundException`, which is exactly what had happened.
+4. **Drive four with real arguments** and check their output contains what it
+   should: `checksyntax` (`/f <file> /t <vendor>`), `formatsql` (bare filename),
+   `listGSPInfo` (no arguments), and `modifysql`, whose compile and run scripts
+   are named differently (`compile_modifysql.bat` builds the folder,
+   `run_replaceTablename.bat` runs one class).
 
 Each script ends with `pause`, so CI feeds their stdin from `NUL` to keep them
 from blocking on a runner with no keyboard.
 
-Four demos, not all 45, is a deliberate stopping point: they are generated from
-one template and go stale as a set, which is exactly what happened when the
-demos moved directory. The four cover the distinct argument shapes, so a change
-that breaks the template shows up here.
-
+Bringing all 39 under CI turned up four things that were broken and invisible:
+two scripts still compiled `src\main\java\demos\*.java`, a directory deleted
+in the package rename; `compile_analyzesp.bat` in the nested `sybase` folder had
+picked up a doubled `sybase\sybase\` path; both `run_columnImpact.bat` files
+named a package that no longer existed; and seven demos could not compile at all
+because their scripts pass only their own folder to `javac` while the classes
+import across demos — fixed by adding `-sourcepath src\main\java`, which lets
+`javac` resolve the rest.
 
 ## Building the dlineage demo on its own
 

pom.xml

@@ -223,11 +223,12 @@
                              Everything else in their packages still builds. -->
                         <exclude>gudusoft/gsqlparser/demos/gettablecolumns/runGetTableColumn.java</exclude>
 
-                        <!-- Redefines myMetaDB / TInfoRecord / SortIgnoreCase,
+                        <!-- TGetTableColumn_notUsed.java was excluded here. It
+                             redefined myMetaDB / TInfoRecord / SortIgnoreCase,
                              which the retained TGetTableColumn.java in the same
-                             package already provides. Its name records that it
-                             is dead. -->
-                        <exclude>gudusoft/gsqlparser/demos/gettablecolumns/TGetTableColumn_notUsed.java</exclude>
+                             package already provides, so it also broke any
+                             wildcard compile of that folder -- which is how
+                             compile_gettablecolumns.bat compiles it. Deleted. -->
                         <exclude>gudusoft/gsqlparser/demos/columninspect/ColumnInspect.java</exclude>
                         <exclude>gudusoft/gsqlparser/demos/dlineage/DataFlowAnalyzer.java</exclude>
                     </excludes>

src/main/java/gudusoft/gsqlparser/demos/analyzescript/compile_analyzescript.bat

@@ -35,7 +35,7 @@ REM # Compile the gsp demo
 REM # javac -d needs the output directory to already exist.
 if not exist %targetdir% mkdir %targetdir%
 
-%JAVAC_CMD% -d %targetdir% -classpath %CLASSPATH% src\main\java\demos\*.java src\main\java\gudusoft\gsqlparser\demos\analyzescript\*.java
+%JAVAC_CMD% -d %targetdir% -sourcepath src\main\java -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzescript\*.java
 
 echo Completed.
 

src/main/java/gudusoft/gsqlparser/demos/analyzesp/compile_analyzesp.bat

@@ -35,7 +35,7 @@ REM # Compile the gsp demo
 REM # javac -d needs the output directory to already exist.
 if not exist %targetdir% mkdir %targetdir%
 
-%JAVAC_CMD% -d %targetdir% -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzesp\Analyze_SP.java
+%JAVAC_CMD% -d %targetdir% -sourcepath src\main\java -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzesp\Analyze_SP.java
 
 echo Completed.
 

src/main/java/gudusoft/gsqlparser/demos/analyzesp/sybase/compile_analyzesp.bat

@@ -35,7 +35,7 @@ REM # Compile the gsp demo
 REM # javac -d needs the output directory to already exist.
 if not exist %targetdir% mkdir %targetdir%
 
-%JAVAC_CMD% -d %targetdir% -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzesp\sybase\sybase\Analyze_SP.java
+%JAVAC_CMD% -d %targetdir% -sourcepath src\main\java -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzesp\sybase\Analyze_SP.java
 
 echo Completed.
 

src/main/java/gudusoft/gsqlparser/demos/analyzeview/compile_analyzeview.bat

@@ -35,7 +35,7 @@ REM # Compile the gsp demo
 REM # javac -d needs the output directory to already exist.
 if not exist %targetdir% mkdir %targetdir%
 
-%JAVAC_CMD% -d %targetdir% -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzeview\Analyze_View.java
+%JAVAC_CMD% -d %targetdir% -sourcepath src\main\java -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\analyzeview\Analyze_View.java
 
 echo Completed.
 

src/main/java/gudusoft/gsqlparser/demos/antiSQLInjection/columnImpact/compile_columnImpact.bat

@@ -35,7 +35,7 @@ REM # Compile the gsp demo
 REM # javac -d needs the output directory to already exist.
 if not exist %targetdir% mkdir %targetdir%
 
-%JAVAC_CMD% -d %targetdir% -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\antiSQLInjection\columnImpact\*.java
+%JAVAC_CMD% -d %targetdir% -sourcepath src\main\java -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\antiSQLInjection\columnImpact\*.java
 
 echo Completed.
 

src/main/java/gudusoft/gsqlparser/demos/antiSQLInjection/columnImpact/run_columnImpact.bat

@@ -26,7 +26,7 @@ call setenv\setenv.bat
     )
 
 REM # Run the gsp demo
-%JAVA_CMD% -cp %CLASSPATH% gudusoft.gsqlparser.demos.columnImpact.ColumnImpact  %1 %2 %3 %4 %5 %6 %7 %8 %9
+%JAVA_CMD% -cp %CLASSPATH% gudusoft.gsqlparser.demos.antiSQLInjection.columnImpact.ColumnImpact  %1 %2 %3 %4 %5 %6 %7 %8 %9
 
 REM # Change back to the original directory
 cd src\main\java\gudusoft\gsqlparser\demos\antiSQLInjection\columnImpact

src/main/java/gudusoft/gsqlparser/demos/antiSQLInjection/compile_antiSQLInjection.bat

@@ -35,7 +35,7 @@ REM # Compile the gsp demo
 REM # javac -d needs the output directory to already exist.
 if not exist %targetdir% mkdir %targetdir%
 
-%JAVAC_CMD% -d %targetdir% -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\antiSQLInjection\*.java
+%JAVAC_CMD% -d %targetdir% -sourcepath src\main\java -classpath %CLASSPATH% src\main\java\gudusoft\gsqlparser\demos\antiSQLInjection\*.java
 
 echo Completed.