You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extract a QuickPayRepo (or similarly named repository) for QuickPay policy + daily spend ledger concerns that are currently spread across AppViewModel, QuickPayViewModel, and CacheStore, so call sites only delegate instead of re-implementing conversion/cap math.
#1159 is a security-facing QuickPay daily spend limit patch. The daily-cap work added enough shared logic that a repository extraction is justified, but applying that refactor in the same PR would:
Expand review surface beyond the security fix
Mix behavioral change with structural move
Slow shipping the patch
Rationale: Keep #1159 limited to the security fix; do this extraction after it is merged.
Goal
Extract a
QuickPayRepo(or similarly named repository) for QuickPay policy + daily spend ledger concerns that are currently spread acrossAppViewModel,QuickPayViewModel, andCacheStore, so call sites only delegate instead of re-implementing conversion/cap math.Why this was deferred from #1159
#1159 is a security-facing QuickPay daily spend limit patch. The daily-cap work added enough shared logic that a repository extraction is justified, but applying that refactor in the same PR would:
Rationale: Keep #1159 limited to the security fix; do this extraction after it is merged.
Scope
In scope
CacheStore, orchestrated from VMs)AppViewModelgating and consistent with pay-time checksOut of scope
payInvoice/ node event watching out ofLightningRepoJourneys
Add
journeys/quickpay/(README + XML), patterned afterjourneys/amount-limits/.Setup: funded spending balance via
bitkit-docker/ LSP; QuickPay enabled.Cover:
Acceptance criteria
masterafter fix: add quickpay daily spend limit #1159 is mergedResult/ simple types as appropriateAppViewModelandQuickPayViewModelno longer duplicate daily-cap / USD conversion mathjourneys/quickpay/documents setup and covers under-cap QuickPay + over-cap Confirmjust compile, targeted unit tests, andjust lintpassReferences