`nb move` to a subdirectory should not break existing links/id

[taniki]

Sorry if this is a duplicated issue. I dug around but have not found anything related.

Right now if one moves a note to a subdirectory, the note is removed from the index. This breaks pre-existing wikilinks.

I don't want to jump directly into solutions because I have no idea how it can be resolved efficiently. Here are some suggestions tho:

• replace the former filename with a fullpath, instead of an empty line, and filter out lines with a folder delimitator to keep consistency with current behaviour
• modify all wikilinks, that's what logseq is doing, for example. I guess this can be easily solved with sed if not considering modifying other notebooks.

That might also help prevent some minor bugs, like nb edit -l on a note that has been moved after it has been modified.

[xwmx]

Thanks for making the issue.

I've thought about this a lot and lean toward mass-updating all wikilinks to the moved item. It's good to know logseq is doing that. It gets a little complicated, which is why I haven't tackled it yet. For example, wiki-style links support titles, notebook selectors, and folder and file names. If we are implementing search and replace for move, then it seems like we'd probably want to use it for renames, too. We also have to consider performance. I have a lot of items and notebooks and it currently takes 25 seconds to perform a search across all notebooks using nb search with git grep.

Enhancing the index format is interesting and something I hadn't considered. I'll have to think about that more, too.