docs(0.15): miden-client for_testnet needs features = ["tonic"] - #369
Open
agent-default wants to merge 1 commit into
Open
docs(0.15): miden-client for_testnet needs features = ["tonic"]#369agent-default wants to merge 1 commit into
agent-default wants to merge 1 commit into
Conversation
The getting-started Cargo.toml still pinned miden-client 0.11 with no features. for_testnet/for_devnet/for_localhost are cfg(feature = "tonic") on 0.15.5, so a binary copied from this page does not compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.15 rust-client library page installs
miden-client = { version = \"0.11\" }and then callsClientBuilder::for_testnet(). On 0.15.5 those constructors are#[cfg(feature = \"tonic\")]; default features arestdonly.This updates the getting-started
Cargo.tomlto0.15.5withfeatures = [\"tonic\"]and notes the cfg gate.Tracked in 0xMiden/rust-sdk#2464 (item 1). Tutorials already pass
tonic; this page did not.Reference: https://github.com/agent-default/miden-agent