feat(network-monitor): add fees support - #2526
Conversation
b5e9f07 to
41c0222
Compare
I think this should not be needed - instead, the sponsorship note should pay for the network transactions. These notes are created by operator account which should have tokens already. Two things to keep in mind here:
|
This works now, but it will need to change at the point when batch builders' tx acceptance criteria change and they require fee payment.
Thanks, good catch! I created a |
Even though the notes are currently priced at 0 and the batch builders will accept transactions with 0 fees, the current situation is that
|
41c0222 to
dc2daab
Compare
|
I moved the deps bump and genesis changes to #2538 , which will be ready to merge after the fix of the protocol releases. |
Closes #2450
Summary
On fee-charging chains the monitor now funds its accounts from the faucet (reusing the existing PoW token-request flow) and keeps itself funded:
FEE_SPONSORSHIPnote that pays for the network transaction consuming it. It also allowlists the sponsorship and P2ID scripts and carriesBasicWallet(as does the wallet, to consume P2ID notes).--faucet-urlfails the monitor at startupMainnet, which has no faucet, is a follow-up.
Also in this PR:
0.16.0-rc.4to0.16.0-rc.6(version pins only, no code changes needed).TEsted it against a live local stack (fee-enabled genesis, base fee 500) with the faucet from 0xMiden/faucet#289: funding, deployment, increments with sponsorships, and automatic top-up all worked end to end.
Changelog