fix(store): error when account sync page cannot make progress - #2530
Open
crazywriter1 wants to merge 4 commits into
Open
fix(store): error when account sync page cannot make progress#2530crazywriter1 wants to merge 4 commits into
crazywriter1 wants to merge 4 commits into
Conversation
Return AccountSyncPageExceedsPayloadLimit for vault and storage-map sync when a single block exceeds the page limit, instead of silently advancing the cursor and dropping updates.
…razywriter1/miden-node into fix/account-sync-page-overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_block_included = block_range.start()when a single block exceeded the row limit, so clients could skip that block and permanently lose updates.SyncTransactionspattern: returnAccountSyncPageExceedsPayloadLimit(RPCout_of_range) when pagination cannot make progress.GetAccountstorage-map reconstruction maps the new error toLimitExceeded.Test plan
cargo test --locked -p miden-node-store --lib all_entries_incargo test --locked -p miden-node-store --lib multi_block_paginationcargo test --locked -p miden-node-store --lib paginates_until_last_blockChangelog