Skip to content

fix(store): error when account sync page cannot make progress - #2530

Open
crazywriter1 wants to merge 4 commits into
0xMiden:nextfrom
crazywriter1:fix/account-sync-page-overflow
Open

fix(store): error when account sync page cannot make progress#2530
crazywriter1 wants to merge 4 commits into
0xMiden:nextfrom
crazywriter1:fix/account-sync-page-overflow

Conversation

@crazywriter1

@crazywriter1 crazywriter1 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Vault and storage-map sync pagination returned an empty page with last_block_included = block_range.start() when a single block exceeded the row limit, so clients could skip that block and permanently lose updates.
  • Match the SyncTransactions pattern: return AccountSyncPageExceedsPayloadLimit (RPC out_of_range) when pagination cannot make progress.
  • GetAccount storage-map reconstruction maps the new error to LimitExceeded.

Test plan

  • cargo test --locked -p miden-node-store --lib all_entries_in
  • cargo test --locked -p miden-node-store --lib multi_block_pagination
  • cargo test --locked -p miden-node-store --lib paginates_until_last_block

Changelog

[[entry]]
scope       = "rpc"
impact      = "fixed"
description = "Account vault and storage-map sync now return an out-of-range error when a single block exceeds the response page limit, instead of silently dropping updates."

crazywriter1 and others added 4 commits August 29, 2026 21:06
Return AccountSyncPageExceedsPayloadLimit for vault and storage-map
sync when a single block exceeds the page limit, instead of silently
advancing the cursor and dropping updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant