Conversation
Bump Dashboard.Models and propagate StatusUpdateTime through CAD status updates.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 121fb4d. Configure here.
| UnitDto globalUnit = GetUnitByName(unit.RadioName); | ||
| globalUnit.StatusId = unit.StatusId; | ||
| globalUnit.StatusCode = unit.StatusCode; | ||
| globalUnit.StatusUpdateTime = unit.StatusUpdateTime; |
There was a problem hiding this comment.
Default timestamp clears global unit
Medium Severity
In AddOrUpdateIncidentUnit, assigning globalUnit.StatusUpdateTime from the incoming UnitAssignmentDto always runs, so a payload without StatusUpdateTime (default DateTime) overwrites a timestamp previously set on the global unit—for example via UpdateUnitStatus—with an invalid default value.
Reviewed by Cursor Bugbot for commit 121fb4d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Dashboard.Modelssubmodule to includeStatusUpdateTimeonUnitDtoandUnitAssignmentDtoStatusUpdateTimebetween global units and incident assignments in CADDateTime.UtcNowinUpdateUnitStatusso the status-id-only SignalR path still populates the fieldCloses #47
Test plan
StatusUpdateTimeon both DTOsIncidentUnitStatusChangedwith aUnitAssignmentDtothat includesStatusUpdateTimeand verify it is stored on both the assignment and the matching global unitUnitStatusChanged(radioName, statusId)and verify the unit’sStatusUpdateTimeis setmain(post-45 add support for native docker deploymnet #46) and confirm no conflictsMade with Cursor