Document ARIA mappings for enum-valued properties - #764
Merged
Conversation
DataTriny
requested changes
Aug 16, 2026
DataTriny
left a comment
DataTriny
left a comment
Member
There was a problem hiding this comment.
Looks good, just one comment.
| /// Whether and how this node represents the current item within a set. ARIA | ||
| /// equivalent: [`aria-current`]. | ||
| /// | ||
| /// **Difference with ARIA:** `aria-current` accepts unrecognized non-empty |
Member
There was a problem hiding this comment.
The difference is obvious and already enforced by the type system, I don't think it's even worth mentioning here.
Contributor
Author
There was a problem hiding this comment.
Done. Apologies for the deleay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the documentation work by covering the enum-valued properties.
The two differences I found are that
Toggledcombines the separatearia-checkedandaria-pressedstates based on the node's role, andAriaCurrentsupports the defined enum values while ARIA also treats unrecognized non-empty tokens astrue.I ran:
cargo fmt --all -- --checkRUSTDOCFLAGS="-D warnings" cargo doc -p accesskit --no-depscargo test -p accesskit