Configure shared MCP servers - #697
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b5db6de. Configure here.
| } | ||
| $serverKey = $jsonConfigs[$path] | ||
| $servers = $json.$serverKey | ||
| $hasSharedServer = $null -ne $servers -and $null -ne $servers.PSObject.Properties['github'] |
There was a problem hiding this comment.
Validator crashes on missing server collection
Medium Severity
The new shared-only check reads $json.$serverKey outside the existing try while Set-StrictMode -Version Latest is on. A present JSON config that omits mcpServers, servers, or mcp now throws and aborts the validator instead of recording UNH-MCP-INVALID.
Reviewed by Cursor Bugbot for commit b5db6de. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Agent clients lose shared MCP access after rebuilds and fresh clones.
What:
Note
Medium Risk
Changes devcontainer lifecycle, credential resolution, and gitignored MCP client files; mitigated by launchers that fail closed, no secrets in configs, and new contract tests.
Overview
Adds a shared MCP catalog (GitHub’s official Docker server plus Z.AI Vision, Web Search, Web Reader, and Zread) and wires it into every supported agent client through a new
configure-sharedpath inunity-mcp.mjs, withnpm run mcp:configure-sharedfor manual repair. Unityconfigurenow merges the same shared entries alongsideunity-mcp-remoteinstead of only writing the bridge.Launchers (
github-mcp.mjs,zai-mcp.mjs) resolve secrets at runtime (environment →.env.local→ GitHub token cache) and refuse unauthenticated starts; tokens go to Docker via env or a mode-0600 header file, not generated MCP configs or argv.The devcontainer pre-installs
@z_ai/mcp-serverandmcp-remote, mounts persistent agent state, forwardsGITHUB_PERSONAL_ACCESS_TOKENandZ_AI_API_KEY, runs shared config on create/start (before Unity), and background-pulls the GitHub MCP image.validate-mcp-configaccepts shared-only configs when Unity is unavailable.Reviewed by Cursor Bugbot for commit b5db6de. Bugbot is set up for automated code reviews on this repo. Configure here.