Migrate the build orchestrator from NUKE to Fallout (10.4.0) - #60
Open
lahma wants to merge 1 commit into
Open
Conversation
Fallout (fallout.build) is the maintained hard-fork successor of NUKE. The migration follows the shape of the sibling AngleSharp repos: fallout-migrate rewrote the namespaces and pinned Fallout.Common 10.4.0 (the stable channel), the build project moved from nuke/ to build/ (the Fallout convention), and the bootstrap scripts became thin shims that run `dotnet tool restore` + `dotnet fallout`, resolving the CLI (Fallout.GlobalTool) from .config/dotnet-tools.json. The build project now targets net10.0, which the CLI requires; CI invokes the bootstrap scripts, which provision the SDK, so the workflow needs no changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
lahma
marked this pull request as ready for review
August 8, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the build orchestration from NUKE 9.0.4 (unmaintained) to Fallout v10.4.0, the maintained hard-fork successor, matching the rest of the AngleSharp family (core moved in AngleSharp/AngleSharp#1275; Css/Js/Io/Xml/Renderer/Wasm use the same shim + tool-manifest model this PR adopts).
What changed:
fallout-migrate(10.4.0) rewrote theNuke.*namespaces, renamed.nuke/→.fallout/, and pinnedFallout.Common10.4.0 (stable channel — resolves the patchedSystem.Security.Cryptography.Xml10.0.10; restore of the build project is audit-clean)nuke/→build/(the Fallout CLI's convention), and its TFM bumped net8.0 → net10.0 (the CLI requires .NET 10)build.ps1/build.shbecame thin shims (taken from AngleSharp.Js): the dotnet-provisioning block stays, theNUKE_ENTERPRISE_TOKENfeedz block and the direct build-and-run of_build.csprojare gone, and they end withdotnet tool restore+dotnet fallout <args>. The CLI (Fallout.GlobalTool10.4.0) resolves from the new.config/dotnet-tools.json. Positional targets and-Target Xbehave exactly as before, so the hand-writtenci.ymlneeds no changes — the scripts provision the SDK themselves.gitignore: NUKE artifact paths → Fallout/build/equivalents; stale nuke.build plugin comment dropped fromBuild.csVerification (local, Windows):
dotnet build build/_build.csproj— 0 warnings, restore audit-clean../build.ps1 Compileend to end (tool restore resolves GlobalTool 10.4.0, Fallout Execution Engine 10.4.0.15). Full default target: RunUnitTests Succeeded — Failed: 0, Passed: 557 (cross-checked with a directdotnet testrun). Publish targets intentionally not run — their code paths changed by namespace only.Pre-existing findings surfaced by the runs, deliberately not touched here: CA1515 warnings in test sources, and NU1902 for the referenced
AngleSharp1.1.2 (moderate advisory) — both exist ondevelalready and are separate concerns.🤖 Generated with Claude Code