rust_binder: fix compilation error due to Owned<Page> allocation - #559
Closed
Neko-0v0 wants to merge 1 commit into
Closed
rust_binder: fix compilation error due to Owned<Page> allocation#559Neko-0v0 wants to merge 1 commit into
Neko-0v0 wants to merge 1 commit into
Conversation
…d50740e253) Signed-off-by: Neko-0v0 <neko@cytus.xyz>
Member
|
thanks, I think I just disabled binder (because it's not enabled inn linux distros) and then forgot about it. manually merged, will appear in the next tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 34d50740e253 makes
PageOwnableand returnsOwned<Page>inalloc_page, which is unexpected for rust_binder and causes compilation error whenCONFIG_ANDROID_BINDER_IPC_RUST=y.This patch fixes the problem. Tested on Mac mini M2, Asahi Arch Linux ARM, kernel 7.1.5.