Conversation
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If proxy construction or selection is wrong, Whisper audio and the API credential may be sent through an unintended intermediary, exposing data or access that a revert cannot undo. Reverting stops future requests from using the proxy, but it cannot retract requests already transmitted.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
buyun14
pushed a commit
to buyun14/AstrBot
that referenced
this pull request
Sep 3, 2026
casama233
force-pushed
the
fix/whisper-stt-proxy
branch
from
September 8, 2026 23:40
065e1a2 to
005bced
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
python -m pytest -q /tmp/test_whisper_api_source.py: 2 passed.python -m ruff check ...: All checks passed.Checklist / 检查清单
Summary by Sourcery
Honor provider proxy settings for OpenAI Whisper transcription requests.
Bug Fixes:
Tests: