Skip to content

[ARM] Fix Deployment Stacks What-If "NoEffect" change type rendering - #33858

Open
Kyle Albert (kalbert312) wants to merge 2 commits into
Azure:devfrom
kalbert312:kylea/stacks-what-if-fixes
Open

[ARM] Fix Deployment Stacks What-If "NoEffect" change type rendering#33858
Kyle Albert (kalbert312) wants to merge 2 commits into
Azure:devfrom
kalbert312:kylea/stacks-what-if-fixes

Conversation

@kalbert312

@kalbert312 Kyle Albert (kalbert312) commented Aug 6, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes Tests
️✔️ None ️✔️ 130/130

Related command
az stack-whatif

Description
Fixes rendering issue with stacks what-if.

Testing Guide
Refer to the unit tests for rendering related updates.

History Notes

[ARM] az stack-whatif: Resource changes with the type "NoEffect" are now colored gray and marked with a cross symbol instead of using the same appearance as the "NoChange" change type


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@kalbert312 Kyle Albert (kalbert312) changed the title [ARM] Deployment Stacks What-If bug fixes. [ARM] Deployment Stacks What-If bug fixes Aug 6, 2026
@kalbert312 Kyle Albert (kalbert312) changed the title [ARM] Deployment Stacks What-If bug fixes [ARM] Fix Deployment Stacks What-If "NoEffect" change type rendering. Aug 6, 2026
@kalbert312
Kyle Albert (kalbert312) marked this pull request as ready for review August 6, 2026 19:36
@kalbert312
Kyle Albert (kalbert312) requested a review from a team as a code owner August 6, 2026 19:36
Copilot AI lite review requested due to automatic review settings August 6, 2026 19:36
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@kalbert312 Kyle Albert (kalbert312) changed the title [ARM] Fix Deployment Stacks What-If "NoEffect" change type rendering. [ARM] Fix Deployment Stacks What-If "NoEffect" change type rendering Aug 6, 2026
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kalbert312

Copy link
Copy Markdown
Member Author

Updated history note.

@azure-client-tools-agent

Copy link
Copy Markdown
Contributor

Live test results — azdev test --live --series (changed test files only)

PASS

Selectors: test_stack_formatters (module)
PR head ref: kylea/stacks-what-if-fixes
PR head sha: 135eee8b0ff392fb936ba1a98ed4997fe14f7dc3
PR base ref: dev
New test files in PR: false

Changed test files run
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_stack_formatters.py

Workflow run: https://github.com/Azure/issue-sentinel/actions/runs/32222495119

Last 80 lines of azdev output

=============
| Run Tests |
=============


=====================
| Discovering Tests |
=====================

/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:13533: SyntaxWarning: invalid escape sequence '\]'
  self.cmd('vmss application set -g {rg} -n {vmss} --app-version-ids {vid1} {vid2} --enable-automatic-upgrade True\]', checks=[
/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/identity/tests/latest/test_identity.py:18: SyntaxWarning: invalid escape sequence '\{'
  'resource_restriction_compute': '\{"providers":\["Microsoft.Compute"\]\}',
/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/identity/tests/latest/test_identity.py:19: SyntaxWarning: invalid escape sequence '\{'
  'resource_restriction_empty': '\{"providers":\[\]\}'

test index updated: /home/runner/.azdev/env_config/home/runner/work/issue-sentinel/issue-sentinel/.venv/test_index/latest.json

Test on modules: test_stack_formatters

WARNING: RUNNING TESTS LIVE
The tests are set to run against current profile "latest"
============================= test session starts ==============================
platform linux -- Python 3.12.13, pytest-9.1.1, pluggy-1.6.0 -- /home/runner/work/issue-sentinel/issue-sentinel/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli
plugins: forked-1.7.5, xdist-3.8.0
collecting ... collected 2 items

azure-cli/src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_stack_formatters.py::TestStacksWhatIfResultFormatter::test_what_if_1 PASSED [ 50%]
azure-cli/src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_stack_formatters.py::TestStacksWhatIfResultFormatter::test_what_if_2 PASSED [100%]

- generated xml file: /home/runner/work/issue-sentinel/issue-sentinel/test-output/results.xml -
============================== 2 passed in 0.37s ===============================

Posted by agent-assist live-test workflow.

@azure-client-tools-agent azure-client-tools-agent Bot added the azure-client-tools-agent Pull request reviewed by Azure Client Tools Agent label Aug 19, 2026

@azure-client-tools-agent azure-client-tools-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Summary

This PR currently has failing checks that need attention before it can be merged:

Please review the linked check logs, address the build failure, and update the PR title/description to match the required format (see the PR template and title guidelines). Once fixed, CI will re-run automatically.

@azure-client-tools-agent azure-client-tools-agent Bot removed the Azure Client Tools Agent Requested Request Azure Client Tools Agent testing and review label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-client-tools-agent Pull request reviewed by Azure Client Tools Agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants