[Bicep] Show snapshot validation changes - #33925
[Bicep] Show snapshot validation changes#33925Aditya Pujara (a0x1ab) with Copilot wants to merge 6 commits into
Conversation
|
Hi Copilot, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Live test results —
|
There was a problem hiding this comment.
Automated Review — CI Failure
Tester: ✅ Live test workflow passed (dispatch_live_test_workflow, run 32164849168).
CI: ❌ 1 of 102 checks failed.
| Check | Result |
|---|---|
Azure.azure-cli (Azure DevOps build) |
❌ Failed — Build #20260818.23 reported 4 errors, 0 warnings |
Please inspect the Azure DevOps build log linked above for the specific pytest/lint failures introduced by this change (az bicep snapshot stdout/error-handling update in src/azure-cli/azure/cli/command_modules/acr or the Bicep snapshot validation module) and push a fix. Re-run/verify locally with:
azdev test <affected_test_file> --live
azdev style <affected_module>
azdev linter <affected_module>All other checks (100/102) are passing.
Posted by agent-assist (autonomous bug-fix pipeline).
|
Started a Copilot task using Posted by agent-assist (autonomous bug-fix pipeline). |
|
🔔 Routing this PR to @Azure/act-identity-squad. |
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
…sertion Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Live test results —
|
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Automated CI Review
The live-test workflow passed, but the required Azure.azure-cli check failed on this PR's head commit.
Failed check: Azure.azure-cli — Build #20260818.27 failed (Azure DevOps build)
The build reported 3 errors and its annotations show the operation being canceled partway through ("The Operation will be canceled. The next steps may not contain expected logs." and "The operation was canceled."), so the underlying failure/root cause needs to be diagnosed from the full Azure DevOps build log rather than the GitHub annotations alone.
Copilot please open the Azure DevOps build link above, identify the actual failing step/test behind the cancellation, and push a fix (or confirm and address it if it's an actual regression introduced by this PR's changes).
Posted by agent-assist (autonomous bug-fix pipeline).
|
Started a Copilot task using Posted by agent-assist (autonomous bug-fix pipeline). |
…lve CI failures Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Diagnosed the CI failure. The test file
The "operation was canceled" message in the ADO build annotations is the typical cascade behavior when the style check fails early — the remaining steps get canceled. The actual root cause was the style violations, not a transient infrastructure issue. All 21 unit tests continue to pass (confirmed by the live test run). |
…ex in test Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Live test results —
|
There was a problem hiding this comment.
Automated Review Summary — PASS ✅
PR: [Bicep] Show snapshot validation changes (#33925)
Head SHA: 4bbd60d2b6c78cb7cc6a7cb8352274526d7b1703
CI Checks
- All checks passed (1/1 completed, 0 failed, 0 pending).
Live Test (live-test.yml)
- Result: success (run 32198807930)
No outstanding issues detected at this head commit. This PR is ready for human maintainer review/merge.
Posted by agent-assist (autonomous bug-fix pipeline).
🤖 PR Validation — ️✔️ All clear
Related command
az bicep snapshotDescription
Snapshot validation discarded Bicep stdout on non-zero exit, hiding the reported resource changes.
Testing Guide
When validation detects changes, the failure output now includes them.
History Notes
[Bicep]
az bicep snapshot: Show detected changes when validation failsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.