Azure Core AMQP 1.0.0-beta.13 release - #7400
Merged
Merged
Conversation
Set the release date and require beta.13 from Event Hubs so its vcpkg package resolves the AMQP APIs it uses. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fcbf47fe-e253-47f0-b947-fb717711cec4
|
Azure Pipelines: Successfully started running 3 pipeline(s). 7 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
added 2 commits
September 3, 2026 11:56
Use the package RTTI macro before dynamic_cast. The no-RTTI build still checks the known exception through a static cast. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fcbf47fe-e253-47f0-b947-fb717711cec4
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fcbf47fe-e253-47f0-b947-fb717711cec4
Johnathan W (j7nw4r)
marked this pull request as ready for review
September 3, 2026 18:10
Johnathan W (j7nw4r)
requested review from
Larry Osterman (LarryOsterman),
Rick Winter (RickWinter),
Josue Gomez (SwayGom),
Anton Kolesnyk (antkmsft),
Ashish Chhabria (axisc),
Eric Lam (MSFT) (hmlam),
Amit Bhatia (meetamitbhatia),
Sagar Patel (sagar0207),
SJ (sjkwak) and
Jeff Fisher (xirzec)
as code owners
September 3, 2026 18:10
|
Azure Pipelines: Successfully started running 3 pipeline(s). 7 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The RTTI-related unit-test fix appears incomplete because another UT still uses an unguarded dynamic_cast and may continue failing/noising in no-RTTI builds.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prepares the azure-core-amqp package for the 1.0.0-beta.13 release and updates downstream consumption in Event Hubs, including a unit test adjustment intended to support builds where RTTI is disabled.
Changes:
- Finalize
azure-core-amqp1.0.0-beta.13changelog with the 2026-09-03 release date and remove empty sections. - Update Event Hubs’ vcpkg manifest to require
azure-core-amqp-cpp>= 1.0.0-beta.13. - Add an RTTI guard in a unit test around typed-exception assertions.
File summaries
| File | Description |
|---|---|
| sdk/eventhubs/azure-messaging-eventhubs/vcpkg/vcpkg.json | Bumps the minimum azure-core-amqp-cpp dependency to beta.13. |
| sdk/core/azure-core-amqp/test/ut/connection_tests.cpp | Adds an RTTI guard around a dynamic_cast-based typed-exception assertion. |
| sdk/core/azure-core-amqp/CHANGELOG.md | Marks beta.13 as released on 2026-09-03 and trims empty sections. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sagar Patel (sagar0207)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare
azure-core-amqp1.0.0-beta.13 for release.Motivation
Event Hubs 1.0.0-beta.15 uses AMQP APIs added after beta.12. Publishing beta.13 unblocks microsoft/vcpkg#53761.
Changes
azure-core-amqp-cpp1.0.0-beta.13 from the Event Hubs vcpkg manifest.Validation
eng/common/scripts/Prepare-Release.ps1forazure-core-amqp1.0.0-beta.13./GR-.Release work item: 16234