Skip to content

[AutoPR azure-resourcemanager-servicefabricmanagedclusters]-generated-from-SDK Generation - Java-6768560 - #50304

Open
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sdkauto/azure-resourcemanager-servicefabricmanagedclusters-6767791
Open

[AutoPR azure-resourcemanager-servicefabricmanagedclusters]-generated-from-SDK Generation - Java-6768560#50304
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sdkauto/azure-resourcemanager-servicefabricmanagedclusters-6767791

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Configurations: 'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', and CommitSHA: 'f4d16444c4bf911d8017bfa1b92365aacef0d130' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6768560 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36354 Submitted by: evanwaldmann@microsoft.com

…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', and CommitSHA: '44920c2ab894014c26ce4a61b0eb5483ecf48280' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6767791 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI lite review requested due to automatic review settings August 31, 2026 20:35
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 31, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
35 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the azure-resourcemanager-servicefabricmanagedclusters management SDK to match a newer azure-rest-api-specs commit and rolls the package forward to 1.2.0-beta.2, along with regenerated metadata and minor JavaDoc changes.

Changes:

  • Updated TypeSpec source commit reference (tsp-location.yaml) and regenerated the metadata JSON.
  • Bumped documentation artifacts for the new beta version (README + CHANGELOG entry/date).
  • Adjusted JavaDoc summaries for restartReplica (and related fluent client methods).

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/tsp-location.yaml Updates the spec commit SHA used for generation.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/resources/META-INF/azure-resourcemanager-servicefabricmanagedclusters_metadata.json Regenerated metadata (cross-language version update).
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/Services.java JavaDoc changes on restartReplica public surface.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/ServiceResource.java JavaDoc changes on restartReplica convenience methods.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/implementation/ServicesClientImpl.java Regenerated implementation JavaDoc (no logic change in shown hunks).
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java JavaDoc changes for begin/restart replica operations in the fluent protocol client.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/README.md Updates dependency snippet to 1.2.0-beta.2.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/CHANGELOG.md Finalizes 1.2.0-beta.2 entry with date and summary line.
Suppressed comments (5)

sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/Services.java:126

  • Same as above: the overload’s doc summary is too generic and doesn’t describe the action or that the call waits for completion.
     * A long-running resource action.

sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/ServiceResource.java:267

  • Same as above: the overload’s doc summary is too generic and should describe the restartReplica action.
     * A long-running resource action.

sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java:280

  • Same as above for the overload: the summary should describe the action being started.
     * A long-running resource action.

sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java:298

  • The doc summary for restartReplica is too generic; since this method blocks (it waits on the poller), the summary should describe the action and the wait behavior.
     * A long-running resource action.

sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java:314

  • Same as above for the overload: the summary should be action-specific and indicate that the call waits for completion.
     * A long-running resource action.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.


/**
* The restartReplica operation.
* A long-running resource action.
@github-actions

Copy link
Copy Markdown
Contributor

Automated management AutoPR review

  • Head SHA: 3aff33536d0cea036f2a4bfec6a03e8e33b9649e
  • Package: azure-resourcemanager-servicefabricmanagedclusters
  • Release type: beta
  • API version: 2026-05-01-preview
  • CHANGELOG: 1.2.0-beta.2 (2026-08-31)
  • Java changes reviewed: JavaDoc-only changes to restartReplica in ServicesClient, ServicesClientImpl, ServiceResource, and Services.
  • Breaking changes: none
  • Decision: no high-confidence concerns

Informational

  • [MGMT-API-VERSION] New — sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/CHANGELOG.md, release 1.2.0-beta.2 (2026-08-31), records generated API version 2026-05-01-preview.

Automated management AutoPR review by Management AutoPR Review: https://github.com/Azure/azure-sdk-for-java/actions/runs/33436834717. Advisory only.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2e3615d9-62b8-4494-a517-9932780acb81
@waldmannly

Copy link
Copy Markdown
Member

Weidong Xu (@weidongxu-microsoft) Haoling Dong (@haolingdong-msft) Xiaofei Cao (@XiaofeiCao) Arthur Ma (@ArthurMa1978) CI is green after adding the required Other Changes changelog section. The generated package continues to target API version 2026-05-01-preview. Could an SDK owner please review and approve this release-plan PR?

…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', and CommitSHA: 'f4d16444c4bf911d8017bfa1b92365aacef0d130' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6768560 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-resourcemanager-servicefabricmanagedclusters]-generated-from-SDK Generation - Java-6767791 [AutoPR azure-resourcemanager-servicefabricmanagedclusters]-generated-from-SDK Generation - Java-6768560 Aug 31, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2e3615d9-62b8-4494-a517-9932780acb81
@weidongxu-microsoft

Copy link
Copy Markdown
Member

/azp run java - servicefabricmanagedclusters - mgmt - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@weidongxu-microsoft

Copy link
Copy Markdown
Member

bot: Live test passed.

@weidongxu-microsoft

Weidong Xu (weidongxu-microsoft) commented Sep 1, 2026

Copy link
Copy Markdown
Member

seems no real code change (doc aside)?

but anyway approved. whether to merge and release is up to service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants