[AutoPR azure-resourcemanager-servicefabricmanagedclusters]-generated-from-SDK Generation - Java-6768560 - #50304
Conversation
…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', and CommitSHA: '44920c2ab894014c26ce4a61b0eb5483ecf48280' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6767791 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates the azure-resourcemanager-servicefabricmanagedclusters management SDK to match a newer azure-rest-api-specs commit and rolls the package forward to 1.2.0-beta.2, along with regenerated metadata and minor JavaDoc changes.
Changes:
- Updated TypeSpec source commit reference (
tsp-location.yaml) and regenerated the metadata JSON. - Bumped documentation artifacts for the new beta version (README + CHANGELOG entry/date).
- Adjusted JavaDoc summaries for
restartReplica(and related fluent client methods).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/tsp-location.yaml | Updates the spec commit SHA used for generation. |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/resources/META-INF/azure-resourcemanager-servicefabricmanagedclusters_metadata.json | Regenerated metadata (cross-language version update). |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/Services.java | JavaDoc changes on restartReplica public surface. |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/ServiceResource.java | JavaDoc changes on restartReplica convenience methods. |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/implementation/ServicesClientImpl.java | Regenerated implementation JavaDoc (no logic change in shown hunks). |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java | JavaDoc changes for begin/restart replica operations in the fluent protocol client. |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/README.md | Updates dependency snippet to 1.2.0-beta.2. |
| sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/CHANGELOG.md | Finalizes 1.2.0-beta.2 entry with date and summary line. |
Suppressed comments (5)
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/Services.java:126
- Same as above: the overload’s doc summary is too generic and doesn’t describe the action or that the call waits for completion.
* A long-running resource action.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/models/ServiceResource.java:267
- Same as above: the overload’s doc summary is too generic and should describe the
restartReplicaaction.
* A long-running resource action.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java:280
- Same as above for the overload: the summary should describe the action being started.
* A long-running resource action.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java:298
- The doc summary for
restartReplicais too generic; since this method blocks (it waits on the poller), the summary should describe the action and the wait behavior.
* A long-running resource action.
sdk/servicefabricmanagedclusters/azure-resourcemanager-servicefabricmanagedclusters/src/main/java/com/azure/resourcemanager/servicefabricmanagedclusters/fluent/ServicesClient.java:314
- Same as above for the overload: the summary should be action-specific and indicate that the call waits for completion.
* A long-running resource action.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| /** | ||
| * The restartReplica operation. | ||
| * A long-running resource action. |
Automated management AutoPR review
Informational
|
…anagedclusters-6767791
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2e3615d9-62b8-4494-a517-9932780acb81
|
Weidong Xu (@weidongxu-microsoft) Haoling Dong (@haolingdong-msft) Xiaofei Cao (@XiaofeiCao) Arthur Ma (@ArthurMa1978) CI is green after adding the required Other Changes changelog section. The generated package continues to target API version 2026-05-01-preview. Could an SDK owner please review and approve this release-plan PR? |
…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', and CommitSHA: 'f4d16444c4bf911d8017bfa1b92365aacef0d130' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6768560 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2e3615d9-62b8-4494-a517-9932780acb81
|
/azp run java - servicefabricmanagedclusters - mgmt - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
bot: Live test passed. |
|
seems no real code change (doc aside)? but anyway approved. whether to merge and release is up to service. |
Configurations: 'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', and CommitSHA: 'f4d16444c4bf911d8017bfa1b92365aacef0d130' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6768560 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36354 Submitted by: evanwaldmann@microsoft.com