preserve integer width in JsonExporter::fromJson - #1186
Open
aysha-afrah26 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExportBlackboardToJSON writes int64_t and uint64_t entries out at full width, but fromJson read every JSON integer back with nlohmann's get(), which is just a static_cast of the stored 64-bit value with no range check. Anything outside the int32 range wraps silently, so a saved int64_t of 5000000000 comes back as 705032704 and 4294967296 comes back as 0, and the same happens to any value fed through ImportBlackboardFromJSON or ImportTreeFromJSON when restoring tree state. I hit it doing an export/import round-trip and noticing the restored counter no longer matched. The fix keeps the width during import: values that fit in int stay int, larger magnitudes stay uint64_t or int64_t to match what toJson already emits. Small integers are unaffected, so the common case behaves exactly as before. Added a regression test that imports the out-of-range values and checks the round-trip.