fix(sdk-coin-flrp): harden FLRP transaction credential guards - #9702
Draft
ralph-bitgo[bot] wants to merge 6 commits into
Draft
fix(sdk-coin-flrp): harden FLRP transaction credential guards#9702ralph-bitgo[bot] wants to merge 6 commits into
ralph-bitgo[bot] wants to merge 6 commits into
Conversation
Harden FLRP transaction credential handling by preserving the distinction\nbetween missing and empty credentials, reporting only signatures shared\nby every credential, and rejecting incomplete credential sets before\nbroadcast. This prevents parsed partially-signed transactions from\nregenerating placeholders or broadcasting invalid signatures.\n\nTicket: CECHO-2035 Session-Id: e9ac6d30-ad79-4eed-a11e-b4a790a58c02 Task-Id: 9881dc02-2bf1-4178-aeea-d6704ec0d405
Add FLRP regression coverage for established empty credentials and mixed real-signature/address-placeholder states. These cases ensure the credential hardening remains effective against the partial-signing paths that caused invalid broadcast signatures.\n\nTicket: CECHO-2035 Session-Id: e9ac6d30-ad79-4eed-a11e-b4a790a58c02 Task-Id: 9881dc02-2bf1-4178-aeea-d6704ec0d405
Use the existing export fixture alias in the new regression tests so the FLRP package type-checks and the guard coverage can execute.\n\nTicket: CECHO-2035 Session-Id: e9ac6d30-ad79-4eed-a11e-b4a790a58c02 Task-Id: 9881dc02-2bf1-4178-aeea-d6704ec0d405
Format the regression assertion according to the package lint rules so the new credential guard test passes the repository's Prettier check.\n\nTicket: CECHO-2035 Session-Id: e9ac6d30-ad79-4eed-a11e-b4a790a58c02 Task-Id: 9881dc02-2bf1-4178-aeea-d6704ec0d405
Cover established empty credentials, incomplete signature intersections, and signing rejection so malformed transactions cannot be regenerated or broadcast. Ticket: CECHO-2035 Session-Id: 783e6dc2-26b9-421c-bab5-aa102e1fad15 Task-Id: 927eb335-15a2-4c41-ba21-bc6b6dc8deb2
Use the credential array directly so established empty credentials fail consistently across signing APIs instead of reaching slot iteration. Ticket: CECHO-2035 Session-Id: 783e6dc2-26b9-421c-bab5-aa102e1fad15 Task-Id: 927eb335-15a2-4c41-ba21-bc6b6dc8deb2
Contributor
ralph-bitgo
Bot
force-pushed
the
CECHO-2035-flrp-credential-guard
branch
from
September 10, 2026 06:37
27f8065 to
f036f2a
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Harden FLRP modern transaction credential handling across signing, signature reporting, and broadcast serialization. Add regression coverage for established empty credentials, incomplete cross-credential signatures, external signing, and mixed ECDSA/address-placeholder states.
Why
Prevent malformed or partially signed transactions from being regenerated, misreported, or broadcast.
Ticket: CECHO-2035