Skip to content

perf(sdk-core): reuse Argon2 session for account password rotation - #9715

Merged
pranavjain97 merged 1 commit into
masterfrom
fix/wcn-2640-account-password-argon2
Sep 10, 2026
Merged

perf(sdk-core): reuse Argon2 session for account password rotation#9715
pranavjain97 merged 1 commit into
masterfrom
fix/wcn-2640-account-password-argon2

Conversation

@pranavjain97

@pranavjain97 pranavjain97 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Optimize account password rotation so v2 wallet-key re-encryption performs one Argon2id derivation per rotation instead of one derivation per wallet key.

This is important for users with large wallet portfolios. Without session reuse, rotating an account password across hundreds or thousands of wallets would repeatedly run Argon2id and could cause severe latency or browser resource
pressure.

WCN-2640

@linear-code

linear-code Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

WCN-2640

@pranavjain97
pranavjain97 force-pushed the fix/wcn-2640-account-password-argon2 branch from 7823eb7 to 0722914 Compare September 10, 2026 18:59
@pranavjain97
pranavjain97 force-pushed the fix/wcn-2640-account-password-argon2 branch from 0722914 to e86be12 Compare September 10, 2026 19:02
@pranavjain97 pranavjain97 changed the title perf(sdk-core): cache account password rotation encryption perf(sdk-core): reuse Argon2 session for account password rotation Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@pranavjain97
pranavjain97 marked this pull request as ready for review September 10, 2026 19:31
@pranavjain97
pranavjain97 requested review from a team as code owners September 10, 2026 19:31

@danielpeng1 danielpeng1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranavjain97
pranavjain97 merged commit 209e4c1 into master Sep 10, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants