fix(wasm-mps): migrate legacy EdDSA MPCv2 keyshares - #388
Open
Marzooqa wants to merge 1 commit into
Open
Conversation
Marzooqa
force-pushed
the
marzooqakather498/wci-1496-add-old-struct-decode-fallback-migration-for-eddsa-mpcv2
branch
2 times, most recently
from
September 9, 2026 13:50
32e0974 to
635a545
Compare
Marzooqa
force-pushed
the
marzooqakather498/wci-1496-add-old-struct-decode-fallback-migration-for-eddsa-mpcv2
branch
from
September 9, 2026 14:35
635a545 to
351842e
Compare
Marzooqa
marked this pull request as ready for review
September 9, 2026 14:47
vibhavgo
reviewed
Sep 10, 2026
There was a problem hiding this comment.
Does ed25519_hard_derive_round0_process also need to use decode_keyshare for root_share around line 855?
Since root_share is a persisted EdDSA keyshare, won't wallets DKG'd between June 30 and mid-July still fail deserialization during hardened child derivation (e.g., generating new receive addresses or signing with derived addresses), even though their root-key DSG signing is now fixed?
Could we update line 855 to use decode_keyshare::<EdwardsPoint>(root_share)? and add a test case covering hard derivation with a migrated legacy share?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WCI-1496