Feature unit testing - #187
Open
leBronzo1 wants to merge 54 commits into
Open
Conversation
…tup for the controls test a lot more to come
… from vec math and need to fix sensors
|
Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging. |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
-g3 additionally emits macro definitions, costing ~7x in object size (195MB -> 28MB). The addr2line crash-report workflow only needs line tables, which -g2 provides; verified identical addr2line output. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Dumping every object file added ~600MB to build/ and a couple of seconds to every clean build. Nothing in the repo consumes the files, so make them opt-in with DUMP_OBJS=1 for codegen inspection. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
$(wildcard dir/*/) returns paths with a trailing slash, so the list mixed "libraries" with "libraries/SdFat/". Harmless for -isystem, but make's path functions misbehave on such paths ($(notdir) returns empty, appending yields a double slash), and the list is also used as prerequisites for compile_commands.json where names are compared as strings. Same 22 directories either way; clean build produces identical section sizes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
'make clean build' hands make two goals. Under -j it walks both dependency
graphs concurrently rather than finishing the first goal before starting the
second, so 'rm -rf build' runs while the compile and link rules are writing
into build/, and the build dies partway through:
ld: open() failed, errno=2 for 'build/git_scraper'
Combining the two is not a workflow worth supporting, so document the two
commands to run instead rather than adding machinery to police the combined
form.
FEATURE_DEFINES needs that note most: the flags are not tracked as a
dependency, so objects built without them are not invalidated when they change.
Set them on the FEATURE_DEFINES line, then run 'make clean' and 'make build'.
Also trim the DUMP_OBJS comment to what a reader needs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
# Conflicts: # src/controls/controller.cpp
…ure-unit-testing # Conflicts: # Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for controls, sensors, utils, and filters.