ci: repair the integration workflow - #329
Open
somethingwithproof wants to merge 1 commit into
Open
Conversation
Three defects, all failing open or failing at setup:
- the plugin syntax check redirected find's own output rather than php's, so
PHP errors never reached the grep testing for them; the step could not fail
- MYSQL_AUTH_USR carried a literal tilde, because parameter expansion happens
after tilde expansion, so MySQL was handed a path it could not resolve
- the Cacti checkout took the default branch, which is 1.3 in development and
whose CLI installer currently fatals with an undefined __()
plugin_syslog additionally installed libapache2-mod-php${{ matrix.php }},
which Ubuntu does not package, so apt exited 100 before Cacti was reached.
Verified with actionlint, which is clean on the result.
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR repairs the plugin’s GitHub Actions integration workflow to make it deterministic and fix several workflow/runtime issues encountered across plugins, without changing any plugin PHP code.
Changes:
- Pin the Cacti core checkout to
release/1.2.31to avoid testing against a moving default branch. - Fix
find -exec php -lredirection placement so actionlint/shellcheck no longer flags SC2227. - Fix MySQL authentication by constructing
--defaults-fileusing$HOMEinside therun:block (avoids literal~), and remove the PHP-version-suffixed Apache module install in favor oflibapache2-mod-php.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
somethingwithproof
added a commit
that referenced
this pull request
Aug 17, 2026
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Aug 17, 2026
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Aug 17, 2026
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Aug 17, 2026
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Aug 17, 2026
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
somethingwithproof
added a commit
to somethingwithproof/plugin_syslog
that referenced
this pull request
Aug 17, 2026
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four defects in the integration workflow, found while making the same repair across plugins.
MySQL never authenticated.
MYSQL_AUTH_USR: '--defaults-file=~/.my.cnf'setin
env:keeps the tilde literal, because tilde expansion happens before variableexpansion and a tilde arriving from a variable is not expanded again. Verified in a
Linux container:
Every
mysqlcall in the step was looking for a directory named~. Assigning thevariable inside
run:with$HOMEexpands it.shellcheck SC2227.
find . -exec php -l {} 2>&1 \;binds the redirect tofindrather than tophp, which actionlint rejects. It is not a correctness bug:php -lwrites parse errors to stdout, so the check does catch a broken file eitherway. Moving the redirect to the end clears the lint.
The Cacti checkout floated.
repository: Cacti/cactiwith noref:takesthe default branch, so the plugin was tested against whatever core happened to be
that day. Pinned to
release/1.2.31.The Apache PHP module was version-suffixed.
libapache2-mod-php${{ matrix.php }}names a package the Ubuntu archive does not carry for every matrix entry. The
unversioned
libapache2-mod-phppulls whichever module matches the runner. Note#327 removes the package outright instead; either resolves the install step, and
the workflow configures Apache but never issues an HTTP request, so both work.
Variables are quoted at the point of use and
actionlintpasses.No plugin code is touched.