Skip to content

Fix warning Email alert - #789

Closed
bmfmancini wants to merge 2 commits into
Cacti:developfrom
bmfmancini:develop
Closed

Fix warning Email alert#789
bmfmancini wants to merge 2 commits into
Cacti:developfrom
bmfmancini:develop

Conversation

@bmfmancini

Copy link
Copy Markdown
Member

Fixes #750

Copilot AI lite review requested due to automatic review settings August 17, 2026 02:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@somethingwithproof somethingwithproof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed again: the three warning threshold_value substitutions are internally consistent and my approval stands. Collision note: this edits the type-2 notification block in thold_functions.php, adjacent to the threshold extraction work in #801. Merge this small fix first, then rebase #801 and the other threshold PRs; do not copy these same three hunks into every issue branch.

@somethingwithproof

Copy link
Copy Markdown
Member

CI audit: this PR currently has an empty diff against develop, so there is no remaining plugin change to validate. Its only non-passing check is the obsolete Cacti develop advisory matrix job, which has been stuck in apt-get update for hours. This PR appears obsolete and should be closed rather than changing its head into a CI-only branch.

@bmfmancini bmfmancini closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Type 2 ALERT>WARNING thold_log records alert thresholds instead of warning thresholds

4 participants