Skip to content

fix: GMX live rate broken by non-USDC collateral decimals #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Aug 26, 2026
Merged

fix: GMX live rate broken by non-USDC collateral decimals #2076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/app/api/fee-compare/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,19 @@ async function fetchEdgeXRate(): Promise<{ rate: number; note: string }> {
async function fetchGmxLiveRate(): Promise<{ rate: number; note: string }> {
const cached = rateCache["gmx-v2"];
if (cached && Date.now() - cached.ts < RATE_CACHE_TTL_MS) return cached;
// Filter to USDC-collateral only: other tokens have different decimals,
// making positionFeeAmount/1e6 astronomically wrong.
const query = `{
tradeActions(
where: { positionFeeAmount_isNull: false sizeDeltaUsd_gt: "0" orderType_in: [2, 3, 4] }
where: {
positionFeeAmount_isNull: false
sizeDeltaUsd_gt: "0"
orderType_in: [2, 3, 4]
initialCollateralTokenAddress_in: [
"0xaf88d065e77c8cC2239327C5EDb3A432268e5831",
"0xFF970A61A04b1cA14834A43f5dE4533eBDDB5CC8"
]
}
orderBy: timestamp_DESC
limit: 50
) { sizeDeltaUsd positionFeeAmount }
Expand Down Expand Up @@ -373,6 +383,10 @@ async function fetchGmxTrades(wallet: string): Promise<GmxWalletData> {
positionFeeAmount_isNull: false
sizeDeltaUsd_gt: "0"
orderType_in: [2, 3, 4]
initialCollateralTokenAddress_in: [
"0xaf88d065e77c8cC2239327C5EDb3A432268e5831",
"0xFF970A61A04b1cA14834A43f5dE4533eBDDB5CC8"
]
}
orderBy: timestamp_DESC
limit: 200
Expand Down
Loading