Skip to content

fix: negative fees display — maker rebates shown as earned #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Aug 26, 2026
Merged

fix: negative fees display — maker rebates shown as earned #2077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/components/fee-compare-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,10 @@ function SimBox({
</p>
{sim.saved > 0.5 && (
<p className="text-[10px] text-emerald-500 font-semibold">
{thisName} saved {fmtUsd(sim.saved)}
{sim.multiple && sim.multiple > 1.05
{thisName} total advantage: {fmtUsd(sim.saved)}
{sim.feesActual < -0.01
? ` (${fmtUsd(sim.equivFees)} equiv + ${fmtUsd(Math.abs(sim.feesActual))} earned)`
: sim.multiple && sim.multiple > 1.05
? ` (${fmt(sim.multiple, 1)}x cheaper)`
: ""}
</p>
Expand Down Expand Up @@ -516,7 +518,10 @@ function WalletSide({
</p>
{crossSim.saved > 0.5 && (
<p className="text-[10px] text-red-400 font-semibold">
{venue.name} would cost {fmtUsd(Math.abs(crossSim.saved))} more
{otherVenue.name} total advantage: {fmtUsd(crossSim.saved)}
{crossSim.feesActual < -0.01
? ` (earned ${fmtUsd(Math.abs(crossSim.feesActual))} in rebates)`
: ""}
</p>
)}
{crossSim.saved < -0.5 && (
Expand Down Expand Up @@ -550,10 +555,19 @@ function WalletSide({
</div>

<div>
<p className="font-mono text-3xl font-extrabold tracking-tight leading-none text-ink">
{fmtUsd(fees)}
</p>
<p className="text-xs text-ink-faint mt-1.5">{fmt(avgBps, 2)} bps avg</p>
{fees < -0.01 ? (
<>
<p className="font-mono text-3xl font-extrabold tracking-tight leading-none text-emerald-500">
+{fmtUsd(Math.abs(fees))}
</p>
<p className="text-xs text-emerald-500/70 mt-1">maker rebates earned</p>
</>
) : (
<p className="font-mono text-3xl font-extrabold tracking-tight leading-none text-ink">
{fmtUsd(fees)}
</p>
)}
<p className="text-xs text-ink-faint mt-1.5">{fmt(Math.abs(avgBps), 2)} bps avg</p>
</div>

{/* Venue-specific extra stats */}
Expand Down