feat: effective rate in rate card + funding in wallet analysis - #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
1. Rate card inconsistency
Rate card showed Gains global avg (5.31 bps) but simulation used BTC-specific rate (3.50 bps) → contradictory winner badge. Now: when wallet data exists,
effectiveRateBpsis computed from actual fills (per-coin weighted). Rate card uses it for winner logic, diff, and big number. Shows italic note "X.XX bps actual (your fills)" / "X.XX bps effective (your coins)".2. Funding rate display
SimResultgetsfundingUsd(HL net funding). SimBox shows "+ $X funding received/paid on {venue}" when non-negligible. Net cost tile subtitle changes from generic "after funding" to "fees $X + $Y rcvd" or "fees $X – $Y paid" breakdown.Gains borrowing fees not included (would require separate GnsRolloverFeeCharged event scan).