Skip to content

fix: factor HL funding into comparison (use netCostUsd not feesUsd) #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Aug 26, 2026
+23 −14
Merged

fix: factor HL funding into comparison (use netCostUsd not feesUsd) #2083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/app/api/fee-compare/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ function toChecksumAddress(address: string): string {
function walletStats(slug: string, w: AnyWallet): { notional: number; fees: number } | null {
if (slug === "hyperliquid") {
const x = w as HlWalletData;
return x.fills > 0 ? { notional: x.notionalUsd, fees: x.feesUsd } : null;
return x.fills > 0 ? { notional: x.notionalUsd, fees: x.netCostUsd } : null;
}
if (slug === "gains") {
const x = w as GainsWalletData;
Expand Down Expand Up @@ -727,17 +727,19 @@ export async function GET(req: Request) {
aNotional += notional;
aFees += fee;
}
const aFunding = hlW.fundingUsd;
const aNetCost = aFees - aFunding;
comparison.aToBSim = {
notionalUsed: aNotional,
feesActual: aFees,
feesActual: aNetCost,
equivFees: bEquiv,
saved: bEquiv - aFees,
multiple: aFees > 0 ? bEquiv / aFees : null,
fundingUsd: (venueAResult.wallet as HlWalletData).fundingUsd,
saved: bEquiv - aNetCost,
multiple: aNetCost > 0 ? bEquiv / aNetCost : null,
fundingUsd: aFunding,
};
if (aNotional > 0) {
venueAResult.effectiveRateBps = (aFees / aNotional) * 10000;
venueAResult.effectiveRateNote = `${((aFees / aNotional) * 10000).toFixed(2)} bps actual (your fills)`;
venueAResult.effectiveRateBps = (aNetCost / aNotional) * 10000;
venueAResult.effectiveRateNote = `${((aNetCost / aNotional) * 10000).toFixed(2)} bps net (fees + funding)`;
venueBResult.effectiveRateBps = (bEquiv / aNotional) * 10000;
venueBResult.effectiveRateNote = `${((bEquiv / aNotional) * 10000).toFixed(2)} bps effective (your coins)`;
}
Expand Down Expand Up @@ -776,16 +778,18 @@ export async function GET(req: Request) {
bNotional += notional;
bFees += fee;
}
const bFunding = hlW.fundingUsd;
const bNetCost = bFees - bFunding;
comparison.bToASim = {
notionalUsed: bNotional,
feesActual: bFees,
feesActual: bNetCost,
equivFees: aEquiv,
saved: bFees - aEquiv,
multiple: bFees > 0 ? aEquiv / bFees : null,
fundingUsd: (venueBResult.wallet as HlWalletData).fundingUsd,
saved: bNetCost - aEquiv,
multiple: bNetCost > 0 ? aEquiv / bNetCost : null,
fundingUsd: bFunding,
};
if (bNotional > 0) {
venueBResult.effectiveRateBps = (bFees / bNotional) * 10000;
venueBResult.effectiveRateBps = (bNetCost / bNotional) * 10000;
venueBResult.effectiveRateNote = `${((bFees / bNotional) * 10000).toFixed(2)} bps actual (your fills)`;
venueAResult.effectiveRateBps = (aEquiv / bNotional) * 10000;
venueAResult.effectiveRateNote = `${((aEquiv / bNotional) * 10000).toFixed(2)} bps effective (your coins)`;
Expand Down
9 changes: 7 additions & 2 deletions src/components/fee-compare-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ type FeeCompareResult = {
// ──────────────────────────────────────────────────────────────────────

function walletFees(slug: string, w: AnyWallet): number {
if (slug === "hyperliquid") return (w as HlWalletData).feesUsd;
if (slug === "hyperliquid") return (w as HlWalletData).netCostUsd;
return (w as GainsWalletData | GmxWalletData | DydxWalletData).feesUsdc;
}

Expand Down Expand Up @@ -588,7 +588,12 @@ function WalletSide({
{fmtUsd(fees)}
</p>
)}
<p className="text-xs text-ink-faint mt-1.5">{fmt(Math.abs(avgBps), 2)} bps avg</p>
<p className="text-xs text-ink-faint mt-1.5">
{fmt(Math.abs(avgBps), 2)} bps avg
{venue.slug === "hyperliquid" && (w as HlWalletData).fundingUsd !== 0 && (
<span className="ml-1 text-ink-faint/60">· net of funding</span>
)}
</p>
</div>

{/* Venue-specific extra stats */}
Expand Down
Loading