fix: bToASim saved sign + Gains walletStats netCostUsdc - #2093
Merged
Conversation
- bToASim saved: aEquiv - bNetCost (was reversed, caused wrong advantage display) - bToASim HL effectiveRateNote: use bNetCost not bFees for net bps label - walletStats gains: fees = netCostUsdc (trading + funding + borrowing, consistent with HL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed
stats.fees - equivFees(inverted) → nowequivFees - stats.fees. When venueB is cheaper, saved is now correctly positive and shows venueB advantage (not venueA).bNetCost - aEquiv→ nowaEquiv - bNetCost(same inversion).bFees/notional(trading only) → nowbNetCost/notional(net including funding), consistent with venueA label.feesUsdc(trading only) → nownetCostUsdc(total cost), consistent with HL usingnetCostUsd.These bugs caused the comparison direction to flip when only venueB had wallet data.