fix: dYdX takers-only, drop inaccurate funding, timeout 50s - #2096
Merged
Conversation
Flotapponnier
commented
Aug 26, 2026
Flotapponnier
commented
Collaborator
- dYdX fills: count and fees use takers only (maker rebates excluded)
- dYdX funding: removed perpetualPositions fetch — netFunding is cumulative all-time, can't date-scope it from public API
- maxDuration: 30s → 50s to cover parallel paginated fetches (Gains 6×12s, GMX 7×15s, dYdX 20×10s sequential)
- Gains MAX_PAGES: 10 → 6 (600 trades, ~10s sequential vs 20s before)
- Footnote updated to note dYdX funding exclusion
…ins 6 pages - Remove perpetualPositions funding fetch (not date-scopable, cumulative all-time) - dYdX fills count = takers only (consistent with fee/notional calc) - maxDuration 30 -> 50 to cover paginated fetches in parallel - Gains MAX_PAGES 10 -> 6 (600 trades, safer budget) - Footnote: note dYdX funding excluded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.