Fix #711: Retain sidebar panel state when switching tabs - #2189
Open
Borisserz wants to merge 1 commit into
Open
Conversation
Keep all WorkspacePanelView tab panels mounted and toggle visibility with opacity so navigator and inspector outline expand/scroll state survives switching tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes navigator/inspector sidebar panels resetting expand and scroll state when switching between sidebar tabs.
WorkspacePanelViewpreviously swapped content withif let selection = selectedTab { selection }, which destroyed and recreated AppKit outline views. It now keeps every tab panel mounted in aZStackand toggles visibility with opacity / hit-testing, soNSOutlineViewstate survives.Applies to both the left navigator and right inspector (they share
WorkspacePanelView).Related Issues
Checklist
Screenshots
Please verify locally (UI): expand folders in Project Navigator β switch to Search β switch back β expansion/scroll retained.
Test plan
WorkspacePanelRetentionTests(all tab bodies stay mounted after selection change)SidebarPanelRetentionUITests(expansion survives Project β Search)--stricton touched files (0 violations)Made with Cursor