Sort | Restore Founders Grotesk on category headings - #45
Merged
Conversation
Button reset font: inherit overrode .heading-small and fell back to Times. Co-authored-by: Cursor <cursoragent@cursor.com>
BrianGenisio
marked this pull request as ready for review
August 26, 2026 12:18
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughRemoved 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Category headings on Sort-into-boxes went to Times after the Aug 17 a11y pass turned the heading into a button.
.heading-smallis Founders Grotesk again.Changes
The button reset used
font: inherit/font-family: inherit. Same specificity as.heading-small, later insort.css, so inherit won.bodyhas no font-family, so the UA serif (Times) showed up.Those two declarations are gone. Other button resets stay so keyboard placement still works.
Test plan
sort-into-boxes.mdat/play)