Skip to content

Sort | Restore Founders Grotesk on category headings - #45

Merged
BrianGenisio merged 1 commit into
mainfrom
fix/sort-heading-font
Aug 26, 2026
Merged

Sort | Restore Founders Grotesk on category headings#45
BrianGenisio merged 1 commit into
mainfrom
fix/sort-heading-font

Conversation

@BrianGenisio

@BrianGenisio BrianGenisio commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Category headings on Sort-into-boxes went to Times after the Aug 17 a11y pass turned the heading into a button. .heading-small is Founders Grotesk again.

Changes

The button reset used font: inherit / font-family: inherit. Same specificity as .heading-small, later in sort.css, so inherit won. body has no font-family, so the UA serif (Times) showed up.

Those two declarations are gone. Other button resets stay so keyboard placement still works.

Test plan

  • Open Sort-into-boxes (sort-into-boxes.md at /play)
  • Confirm category titles render in Founders Grotesk, 24px / 500
  • Select a chip and activate a category heading (click or Enter/Space); placement should still work
  • Keyboard-focus a category heading and confirm the drop-target highlight still appears

Button reset font: inherit overrode .heading-small and fell back to Times.

Co-authored-by: Cursor <cursoragent@cursor.com>
@BrianGenisio
BrianGenisio marked this pull request as ready for review August 26, 2026 12:18
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d204109d-e098-4e39-8d71-55fd2ec30363

📥 Commits

Reviewing files that changed from the base of the PR and between e99d435 and 877a392.

📒 Files selected for processing (1)
  • public/modules/sort.css

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

Removed font: inherit and font-family: inherit from .categorization-category-head. The heading now uses typography defined by .heading-small.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary change: restoring Founders Grotesk on Sort category headings.
Description check ✅ Passed The description directly explains the font regression, the CSS fix, retained button-reset styles, and the test plan.

Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit f56bc8c into main Aug 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant